Fixed no-push flag and added compressedCaching option when building skaffold kaniko

[rayshoo]

Fixes: #7008
Fixed kaniko's no-push option.

Fixes: compressedCaching
Added to support kaniko's compressedCaching=false flag.

Description
I used kaniko when building our company's CICD, but while trying to migrate to skaffold for multi-architecture builds, I discovered that the no-push option and compressedCaching=false that I had been using were not possible with skaffold. While testing kaniko when building CICD, I discovered that the no-push option could only be used if there was no destination. Also, when there are a lot of images and the like during build, turning off the compressed caching option was a necessary option because it reduced excessive memory usage, although the build time increased.

User facing changes (remove if N/A)
skaffold enables the use of kaniko's no-push and compressedCaching=false options.

Follow-up Work (remove if N/A)
To add the new flag feature, I looked into reverting the commit that removed the existing no-push feature and added the necessary code.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @rayshoo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances Skaffold's integration with Kaniko by introducing support for two critical Kaniko features: the no-push flag and the compressedCaching option. Previously, users faced limitations when trying to perform builds without pushing to a registry or when managing memory consumption during large builds. This change allows Skaffold users to leverage these Kaniko capabilities, providing greater flexibility and control over their container image build processes, particularly in CI/CD environments where specific build behaviors are required.

Highlights

• Kaniko No-Push Option: Introduced the noPush option for Kaniko builds, allowing users to build container images without pushing them to a registry. This addresses scenarios where only a local build artifact is needed.
• Kaniko Compressed Caching: Added the compressedCaching option for Kaniko, providing control over whether cached layers are compressed. Disabling this can reduce memory usage during large builds, albeit potentially increasing build time.
• Skaffold Integration and Schema Updates: Updated the Skaffold schema, Go types, argument generation logic, and unit tests to fully support the new noPush and compressedCaching Kaniko features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the no-push and compressedCaching options for Kaniko builds. The changes to the configuration schema, argument generation, and default values are all well-implemented. However, the new tests added for these features are currently broken because they don't account for the conditional logic of the --destination flag. I've left comments on the test files with details on the issue. I also found a couple of minor areas for improvement: a small refactoring opportunity in the argument construction logic and a typo in a code comment.

[rayshoo]

I sincerely apologize for the immaturity of my initial PR, as my contribution experience is still limited. Since there were config changes and I noticed that the previous version had already been released, I created a new version and added a commit with the new feature. However, the commit history became cluttered, so I consolidated it into two final commits to keep things cleaner.

I also later discovered that the test code is quite sensitive to the order of Kaniko arguments. Adapting the test code to the main code changes turned out to be more challenging than expected, so I minimized the modifications while still ensuring the tests pass.

Please let me know if there are any additional changes or adjustments you would like me to make. Thank you very much for your time and review.

[rayshoo]

The modified Kaniko no-push works correctly for single-platform builds. However, the issue described in the main text was confirmed to occur in multi-platform builds. The problem appears to arise during the process of generating a new image after each platform build by checking the remote registry metadata. Accordingly, Kaniko no-push was modified to skip this step. While it may not be the optimal solution, tests have shown that it works reliably, including layer caching after the build.

[rayshoo]

I believe it would be more appropriate to split this PR. Therefore, I am reverting b903841 commit and will submit a separate PR specifically addressing the #9861 issue.