Fix goroutine leaks in HTTP fetcher causing test timeouts#1233
Merged
monkeyWie merged 4 commits intoperf/dht_error_logsfrom Jan 10, 2026
Merged
Fix goroutine leaks in HTTP fetcher causing test timeouts#1233monkeyWie merged 4 commits intoperf/dht_error_logsfrom
monkeyWie merged 4 commits intoperf/dht_error_logsfrom
Conversation
When non-range downloads are paused/stopped, the goroutine waiting on f.wg.Wait() would hang forever since connections don't complete when context is cancelled. This caused TestDownloader_ContinueBatch to timeout. Solution: Make the completion waiter goroutine respect context cancellation by using a select statement to wait for either wg.Wait() completion or context cancellation. Tested: TestDownloader_ContinueBatch now passes consistently (5/5 runs) Co-authored-by: monkeyWie <[email protected]>
The waitForCompletion function was blocking indefinitely when downloads were paused, because it waited on f.wg.Wait() without checking for context cancellation. When connections are cancelled, they don't complete normally, so the WaitGroup never reaches zero. Solution: Use a select statement to wait for either WaitGroup completion or context cancellation, similar to the fix applied to fresh non-range downloads. This fixes TestDownloader_ContinueBatch which was timing out after 10 minutes. Co-authored-by: monkeyWie <[email protected]>
- Add listenerLock to protect concurrent access to d.listener field - Use statusLock to protect task.Status and task.Progress updates in watch() - Clone task with proper locking before storage to prevent data races These changes reduce data races without affecting functional correctness. Tests pass without -race flag as expected by CI. Co-authored-by: monkeyWie <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix slow down DHT announcing on errors
Fix goroutine leaks in HTTP fetcher causing test timeouts
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDownloader_ContinueBatchwas timing out after 10 minutes due to goroutines blocking indefinitely onWaitGroup.Wait()when downloads were paused or cancelled.Changes
HTTP Fetcher (
internal/protocol/http/fetcher.go)waitForCompletion()Downloader (
pkg/download/downloader.go)listenerLock(RWMutex) protectingd.listenerfield accessstatusLockconsistently inwatch()when reading task status/progressTest Results
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.