Skip to content

perf: slow down DHT announcing on errors#1186

Merged
monkeyWie merged 55 commits intomainfrom
perf/dht_error_logs
Jan 14, 2026
Merged

perf: slow down DHT announcing on errors#1186
monkeyWie merged 55 commits intomainfrom
perf/dht_error_logs

Conversation

@monkeyWie
Copy link
Member

@monkeyWie monkeyWie commented Nov 25, 2025

Fixed #1181, I noticed that the upstream has already fixed this issue, see anacrolix/torrent@48229c8

@monkeyWie monkeyWie added the perf Performance optimization label Nov 25, 2025
@monkeyWie monkeyWie changed the title perf: Slow down DHT announcing on errors perf: slow down DHT announcing on errors Nov 25, 2025
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 91.39785% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.49%. Comparing base (a9eee26) to head (e9d3eeb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocol/http/helper.go 78.57% 1 Missing and 2 partials ⚠️
internal/protocol/bt/fetcher.go 0.00% 2 Missing ⚠️
internal/protocol/http/fetcher.go 96.92% 1 Missing and 1 partial ⚠️
pkg/download/storage.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
- Coverage   71.74%   71.49%   -0.25%     
==========================================
  Files          47       47              
  Lines        5712     5757      +45     
==========================================
+ Hits         4098     4116      +18     
- Misses       1220     1237      +17     
- Partials      394      404      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@monkeyWie monkeyWie force-pushed the perf/dht_error_logs branch from a4515fd to a7c7e35 Compare January 9, 2026 12:48
@monkeyWie
Copy link
Member Author

@copilot 修复这个问题,然后再重新根据CI test 里的测试命令进行测试验收,直到完全通过

Copy link
Contributor

Copilot AI commented Jan 10, 2026

@monkeyWie I've opened a new pull request, #1232, to work on those changes. Once the pull request is ready, I'll request review from you.

@monkeyWie
Copy link
Member Author

@monkeyWie I've opened a new pull request, #1232, to work on those changes. Once the pull request is ready, I'll request review from you.

@copilot CI还是有问题,继续找问题修复

Copy link
Contributor

Copilot AI commented Jan 10, 2026

@monkeyWie I've opened a new pull request, #1233, to work on those changes. Once the pull request is ready, I'll request review from you.

@monkeyWie monkeyWie force-pushed the perf/dht_error_logs branch from 15cf455 to de5dece Compare January 10, 2026 05:53
@monkeyWie monkeyWie merged commit c9626cb into main Jan 14, 2026
10 of 11 checks passed
@monkeyWie monkeyWie deleted the perf/dht_error_logs branch January 14, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf Performance optimization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gopeed后台狂刷日志

2 participants