Fix race condition causing panic in downloadLoop during pause/resume#1232
Merged
monkeyWie merged 5 commits intoperf/dht_error_logsfrom Jan 10, 2026
Merged
Fix race condition causing panic in downloadLoop during pause/resume#1232monkeyWie merged 5 commits intoperf/dht_error_logsfrom
monkeyWie merged 5 commits intoperf/dht_error_logsfrom
Conversation
…le-close The issue occurred when pause/resume happened rapidly. When doStart() was called again, it created a new channel and assigned it to f.downloadLoopDone. However, the previous downloadLoop's defer closure would then close this NEW channel instead of its own, causing both the old and new downloadLoop to close the same channel, resulting in "panic: close of closed channel". Solution: Pass the channel as a parameter to downloadLoop so each goroutine has its own dedicated channel to close, preventing any possibility of double-close. Tested with 5 consecutive runs of the failing test - all passed. Co-authored-by: monkeyWie <[email protected]>
Co-authored-by: monkeyWie <[email protected]>
Co-authored-by: monkeyWie <[email protected]>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Fix slow down DHT announcing on errors
Fix race condition causing panic in downloadLoop during pause/resume
Jan 10, 2026
monkeyWie
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rapid pause/resume cycles caused
panic: close of closed channelinTestPauseAllAndContinueALLTasks. WhendoStart()recreatedf.downloadLoopDone, the previousdownloadLoop's defer closure would close the new channel instead of its own, causing multiple goroutines to close the same channel.Changes:
downloadLoopDonechannel as parameter todownloadLoop()instead of reading from struct fieldBefore:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.