Searcher Standing Delay #1735
Open
Searcher Standing Delay #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paudar
force-pushed
the
defender-searcher-delay
branch
from
5172c1e to
30b2792
Compare
oleflb
requested changes
Mar 13, 2025
oleflb
requested changes
Mar 14, 2025
paudar
force-pushed
the
defender-searcher-delay
branch
2 times, most recently
from
17adfbd to
effb203
Compare
paudar
force-pushed
the
defender-searcher-delay
branch
2 times, most recently
from
f72ab03 to
de3527d
Compare
oleflb
reviewed
Apr 2, 2025
paudar
force-pushed
the
defender-searcher-delay
branch
from
3627970 to
53d9d62
Compare
|
Right now it fixes the linked issue and should work. TODO (for next issue?) is to refactor behaviour to only have one last_role variable (and not |
paudar
force-pushed
the
defender-searcher-delay
branch
from
53d9d62 to
8a63927
Compare
Storing the last role is rewritten and the behaviour can still be observed in the behaviour simulator |
move functionality of delayed movement of defender that became earcher in searcher make the standing time after role change dynamic depending on last known ball posiiton add senario and fmt rename variable undo change of if condition add new edge detection change ball position in passive_defender_positioning
paudar
force-pushed
the
defender-searcher-delay
branch
from
ac2a36b to
266c328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
Suppress turning of a searcher for a dynamic time after role assignment.
The time depends on the distance to the last known ball position and is scaled with an parameter to estimate a hypothetical ball velocity in m/s towards the robot. The effect only applies in the own half of the field and in the y-coordinates of the penalty box.
Fixes #1395
The way of keeping track of the last role was rewritten to be able to store the time of the last role change.
Ideas for Next Iterations (Not This PR)
Improve assertions in bevihavior standing_searcher simulation.
How to Test
You can see the effects in the
standing_searcher-scenario (incl. defender to searcher change after penalty or in opponent half).