Skip to content

Cleanup linear_algebra #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

schmidma
Copy link
Member

@schmidma schmidma commented Jun 18, 2025

Why? What?

This PR prepares linear_algebra to be published, cleaning up structure and some naming, as well as providing feature flags and documentation.

fixes #1893

@github-project-automation github-project-automation bot moved this to Request for Review in Development Jun 18, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we give a separate version to this crate now? Also let's fill the description, categories, and keywords

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should also add a readme, since that is shown on crates.io

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not touch that yet, as well as renaming of the crate. Did we decide on a publishing scheme?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what you mean, don't you want to publish it to crates.io?


[features]
serde = ["dep:serde"]
path_serde = ["dep:path_serde"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we publish this optional dependency as well?
Does not doing so break crates.io?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure... If that is the case, the only option (besides publishing path_serde as well) would be to provide the path_serde implementations in the path_serde crate...

@schmidma schmidma force-pushed the dont-hesitate-to-maybe-overcompensate branch from 8561922 to 1e86b6e Compare June 23, 2025 08:55
@schmidma schmidma enabled auto-merge June 23, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Request for Review
Development

Successfully merging this pull request may close these issues.

Fix Isometry API inconsistency
3 participants