-
Notifications
You must be signed in to change notification settings - Fork 57
Cleanup linear_algebra
#1890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cleanup linear_algebra
#1890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we give a separate version to this crate now? Also let's fill the description
, categories
, and keywords
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also add a readme, since that is shown on crates.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not touch that yet, as well as renaming of the crate. Did we decide on a publishing scheme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what you mean, don't you want to publish it to crates.io?
|
||
[features] | ||
serde = ["dep:serde"] | ||
path_serde = ["dep:path_serde"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we publish this optional dependency as well?
Does not doing so break crates.io?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure... If that is the case, the only option (besides publishing path_serde
as well) would be to provide the path_serde
implementations in the path_serde
crate...
8561922
to
1e86b6e
Compare
Why? What?
This PR prepares
linear_algebra
to be published, cleaning up structure and some naming, as well as providing feature flags and documentation.fixes #1893