Skip to content

Conversation

@jdchristensen
Copy link
Collaborator

I added "From HoTT " before Require lines that listed Basics, but not if they listed HoTT.Basics or Basics.Overture, for example. So this is as small as change as possible.

Closes #2290

@jdchristensen
Copy link
Collaborator Author

Unfortunately, we can't add From HoTT everywhere. For example, in FreeGroup.v, we have Require Import ... Group ..., and From HoTT Require Import Group fails because of the file Group.v in the test/ folder, which is mapped to HoTT.Tests. For now, I just avoided this, but in the long run having the test/* files and the theories/* files conflict in the HoTT namespace is not a good idea. cc: @Alizter

@jdchristensen
Copy link
Collaborator Author

Ok, this builds and is ready for review.

@jdchristensen
Copy link
Collaborator Author

I'll go ahead and merge, but if anyone has thoughts for improvements, I'm happy to make them later.

@jdchristensen jdchristensen merged commit ee079d1 into HoTT:master Sep 19, 2025
32 of 40 checks passed
@jdchristensen jdchristensen deleted the add-From-HoTT branch September 19, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build error with CI / opam-build (dev, ubuntu-latest) (pull_request)

1 participant