Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibazel: Update test #139337

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Conversation

Neo2308
Copy link
Contributor

@Neo2308 Neo2308 commented Aug 11, 2023

Updated ibazel tests to support go version 1.21 #134468
See bazelbuild/bazel-watcher#617 (comment)

Related to: bazelbuild/bazel-watcher#617

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Aug 11, 2023
@github-actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@Neo2308 Neo2308 changed the title Update ibazel test ibazel: Update test Aug 11, 2023
@stefanb stefanb mentioned this pull request Aug 12, 2023
89 tasks
@chenrui333
Copy link
Member

let's followup on this after go 1.21.0 PR.

@branchvincent branchvincent added the CI-no-bottles Merge without publishing bottles label Aug 12, 2023
@chenrui333
Copy link
Member

shipping go1.21 PR now, will do the rebase

Update ibazel test

Updated ibazel tests to support go version 1.21

Update patch to use bazel 6.3.2

Updated patch to use bazel 6.3.2

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 force-pushed the feature/master/ibazel-go-1.21 branch from 48499c5 to cd1a9c0 Compare August 13, 2023 03:00
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 13, 2023
@chenrui333
Copy link
Member

Thanks @Neo2308!

@chenrui333 chenrui333 added this pull request to the merge queue Aug 13, 2023
Merged via the queue into Homebrew:master with commit 92b8026 Aug 13, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants