feat: ROOT-29: Build control tags dropdown for filtering labels within a specific tag #7700
Conversation
This reverts commit f04db2b.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for heartex-docs canceled.
|
| // if (col.internal) { | ||
| // return; | ||
| // } |
There was a problem hiding this comment.
| // if (col.internal) { | |
| // return; | |
| // } |
There was a problem hiding this comment.
still a WIP, keeping this around until the final pass in case I need it later :)
| // // Filter out internal columns so they never reach grid/column selector | ||
| // return list.filter((c) => !c.internal); |
There was a problem hiding this comment.
| // // Filter out internal columns so they never reach grid/column selector | |
| // return list.filter((c) => !c.internal); |
matt-bernstein
requested review from
hlomzik,
Gondragos and
nick-skriabin
as code owners
matt-bernstein
force-pushed
the
fb-ROOT-29
branch
from
ca65b74 to
6e57f10
Compare
|
/git merge develop
|
|
/fm sync |
| const hasEqualOperators = operatorList.some((o) => ["equal", "not_equal"].includes(o.key)); | ||
| const allowedOperators = hasEqualOperators ? ["equal", "not_equal"] : ["contains", "not_contains"]; |
There was a problem hiding this comment.
so these vars are the same for any operator, so they can be moved out of this filter as a small improvement
| @@ -107,6 +116,9 @@ export const Tab = types | |||
| }, | |||
|
|
|||
| get currentFilters() { | |||
| if (!isFF(FF_ANNOTATION_RESULTS_FILTERING)) { | |||
There was a problem hiding this comment.
it's not a typo? here you are changing the old behaviour without FF and transforming the old one into new one
|
/git merge develop
|
|
/fm sync |
This PR includes the FE changes for the LSE feature https://humansignal.atlassian.net/browse/ROOT-13.
Change to columns: add an
internalflag for "virtual" columns that should not be selectable or viewable in DM; are only used for filtering.Change to filters: allow overriding a column's normal filter behavior with a custom filter expression; used for new columns that do not correspond to a field on the Task model, so the usual ORM behavior doesn't work for them.
orderableflag work properly - was not fully implemented beforeinternalflag