[Fix] Clear cache and storage data on new browser game window #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettCleary
approved these changes
Jan 21, 2025
| @@ -145,14 +146,16 @@ const openNewBrowserGameWindow = async ( | |||
| const hpOverlay = await getHpOverlay() | |||
|
|
|||
| return new Promise((res) => { | |||
| const partition = `persist:${appName}` | |||
jiyuu-jin
approved these changes
Jan 22, 2025
ry-animal
approved these changes
Jan 22, 2025
flavioislima
added
PR: Ready-For-Test
eliobricenov
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should clear the cache of the browser windows when launching games,
It is a workaround for some games like Champz that had issues after games updates.
Another idea would be to clear the cache only when cleaning the hyperplay cache but that might not be intuitive for some users.
How to Test
Not sure since you would need to have an old version of a game loaded, then on the server the game gets updated and then the game launched through hyperplay to trigger the cache clean and be sure that the game would be launched on the latest version.
Use the following Checklist if you have changed something on the Backend or Frontend: