Skip to content

[Fix] Clear cache and storage data on new browser game window #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 27, 2025
Merged

[Fix] Clear cache and storage data on new browser game window #1194

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
807f8b7
[Fix] clear cache and storage data on new browser game window
flavioislima Dec 18, 2024
3a4d228
[Fix] clear cache from partition only
flavioislima Dec 18, 2024
54d9394
Merge branch 'main' into feat-clear-b-game-cache
flavioislima Dec 18, 2024
dea858b
[Fix] partition naming
flavioislima Dec 18, 2024
fb300d7
[Fix] reduce storage data cleared on new browser game window
flavioislima Dec 19, 2024
ea2e79e
chore: pnpm-lock
flavioislima Dec 19, 2024
10dcdd7
Merge branch 'main' into feat-clear-b-game-cache
flavioislima Jan 13, 2025
1b41db2
Merge branch 'main' into feat-clear-b-game-cache
flavioislima Jan 22, 2025
ec49a4f
Merge branch 'main' into feat-clear-b-game-cache
flavioislima Jan 23, 2025
55092eb
Merge branch 'main' into feat-clear-b-game-cache
flavioislima Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/backend/storeManagers/storeManagerCommon/games.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import {
app,
BrowserWindow,
BrowserWindowConstructorOptions,
session,
WindowOpenHandlerResponse
} from 'electron'
import { gameManagerMap } from '../index'
Expand Down Expand Up @@ -145,14 +146,16 @@ const openNewBrowserGameWindow = async (
const hpOverlay = await getHpOverlay()

return new Promise((res) => {
const partition = `persist:${appName}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

const browserGame = new BrowserWindow({
icon: icon,
fullscreen: true,
webPreferences: {
webviewTag: true,
contextIsolation: true,
nodeIntegration: true,
preload: path.join(__dirname, '../preload/preload.js')
preload: path.join(__dirname, '../preload/preload.js'),
partition
},
show: false
})
Expand Down Expand Up @@ -215,6 +218,19 @@ const openNewBrowserGameWindow = async (
}
app.on('web-contents-created', interceptFullscreenKeyInput)

// Clear cache on launch to avoid issues with game updates
const gameSession = session.fromPartition(partition)
gameSession.clearCache()
gameSession.clearStorageData({
storages: ['filesystem', 'shadercache', 'cachestorage'],
quotas: ['temporary', 'syncable']
})

// Open DevTools
if (!app.isPackaged || process.env.HP_ENABLE_DEVTOOLS === 'true') {
browserGame.webContents.openDevTools()
}

browserGame.loadURL(url)
// this is electron's suggested way to prevent visual flash
// https://github.com/electron/electron/blob/main/docs/api/browser-window.md#using-the-ready-to-show-event
Expand Down
Loading