Don't define/use OpenSSL*Callback() for/in OpenSSL > v1.1 #9730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
added
the
core/quality
|
Reference: openssl/openssl#1260 (comment) |
Al2Klimov
force-pushed
the
don-t-define-use-openssl-callback-for-in-openssl-v1-1
branch
from
8441737 to
91a4d0a
Compare
Since OpenSSL v1.1 the macros they're passed to expand to nothing creating the illusion those functions aren't used. That triggers compiler warnings.
Al2Klimov
force-pushed
the
don-t-define-use-openssl-callback-for-in-openssl-v1-1
branch
from
91a4d0a to
8a475b6
Compare
jschmidt-icinga
approved these changes
May 19, 2025
There was a problem hiding this comment.
I've already looked at the associated discussion when you first assigned me to review this, and it looks pretty straight-forward from my POV, since as you say, the macros currently don't do anything.
However, since I'm not entirely in the picture of the range of supported SSL versions, I'd ask you to maybe not rely on my review/approval alone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since OpenSSL v1.1 the macros they're passed to expand to nothing creating the illusion those functions aren't used. That triggers compiler warnings.