Skip to content

Upgrade elastix version to 2025-02-21, inc. TOML support #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 5, 2025

Conversation

N-Dekker
Copy link
Collaborator

Follow-up to pull request #296 commit 39c47c4
"ENH: Bump elastix to 5.2.0, update wasm", Matt McCormick, Aug 12, 2024.

From Jan 2, 2025, elastix required at least ITK v5.4.1:
pull request SuperElastix/elastix#1279
commit SuperElastix/elastix@26abd4f
@N-Dekker N-Dekker force-pushed the Upgrade-elastix-inc-TOML-support branch from bd1d26f to d08d1d5 Compare February 21, 2025 13:33
@N-Dekker
Copy link
Collaborator Author

@thewtex Would it be possible for you to "rebase" you elastix fork onto the latest main revision of SuperElastix/elastix, to make elastix TOML support available to ITKElastix?

SuperElastix/elastix requires ITK 5.4.1 nowadays, but it also appears to work well with ITK 5.4.2, as I tested on an experimental side branch: https://github.com/SuperElastix/elastix/tree/Upgrade-ITK-to-v5.4.2

@thewtex
Copy link
Member

thewtex commented Feb 21, 2025

@N-Dekker yes, will do

@thewtex
Copy link
Member

thewtex commented Feb 21, 2025

@N-Dekker patch here:

4382da4

All the elastix tests passed locally.

Plus ITKElastix patches.
@N-Dekker N-Dekker force-pushed the Upgrade-elastix-inc-TOML-support branch from d08d1d5 to 518f5d1 Compare February 23, 2025 15:11
Includes ITK 5.4.2 support
@N-Dekker N-Dekker changed the title WIP: Upgrade elastix version to 2025-02-21, inc. TOML support Upgrade elastix version to 2025-02-21, inc. TOML support Feb 25, 2025
@N-Dekker N-Dekker marked this pull request as ready for review March 5, 2025 17:51
@thewtex thewtex merged commit d3ca819 into main Mar 5, 2025
19 of 26 checks passed
@thewtex thewtex deleted the Upgrade-elastix-inc-TOML-support branch March 5, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants