Skip to content

COMP: Drop Python 3.8 (end of life) #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025
Merged

COMP: Drop Python 3.8 (end of life) #319

merged 1 commit into from
Mar 5, 2025

Conversation

N-Dekker
Copy link
Collaborator

@N-Dekker N-Dekker commented Mar 4, 2025

Python 3.8 is officially unsupported from 2024-10-07. Python 3.9 should remain supported until October, according to https://devguide.python.org/versions/

Python 3.8 is officially unsupported from 2024-10-07. Python 3.9 should remain
supported until October, according to https://devguide.python.org/versions/
@N-Dekker N-Dekker requested review from thewtex and tbirdso March 4, 2025 12:33
@N-Dekker
Copy link
Collaborator Author

N-Dekker commented Mar 4, 2025

I found four occurrences of python_version < '3.8' in wasm/python/itkwasm-elastix-emscripten/pixi.lock and 47 (!!!) occurrences of requires_python: '>=3.8' in wasm/python pixi.lock files.

Not sure how to address them, are they all necessary? It seems redundant to literally mention the very same version so many times.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @N-Dekker

@thewtex
Copy link
Member

thewtex commented Mar 4, 2025

Not sure how to address them, are they all necessary? It seems redundant to literally mention the very same version so many times.

Changing the value in pyproject.toml should address the lockfile, which is generated.

I think we may want to merge this and #314 and resolve the remaining issues from there. I may have addressed this in #314

@N-Dekker N-Dekker marked this pull request as ready for review March 5, 2025 17:40
@N-Dekker
Copy link
Collaborator Author

N-Dekker commented Mar 5, 2025

I think we may want to merge this and #314 and resolve the remaining issues from there. I may have addressed this in #314

OK, thanks @thewtex, so then please merge this you think it's OK! 😃

@thewtex thewtex merged commit b78f35b into main Mar 5, 2025
22 of 23 checks passed
@thewtex thewtex deleted the Drop-Python-3.8 branch March 5, 2025 18:11
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Mar 5, 2025
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Mar 5, 2025
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Mar 5, 2025
@N-Dekker
Copy link
Collaborator Author

N-Dekker commented Mar 6, 2025

Changing the value in pyproject.toml should address the lockfile, which is generated.

@thewtex So now we have updated the pyproject.toml files, but the "pixi.lock" files aren't yet re-generated. Is it still necessary to re-generate those "pixi.lock" files?

@thewtex
Copy link
Member

thewtex commented Mar 6, 2025

@N-Dekker yes, I'll take a pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants