Feature/276 new script file for testing framework by rolandoquesada · Pull Request #238 · IntelLabs/vdms

rolandoquesada · 2024-10-23T07:27:55Z

No description provided.

…cripts

…github.com/IntelLabs/vdms into feature/276_new_script_file_for_testing_01

remote_function/udf_server.py

tests/remote_function_test/udf_server.py

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

… C++ tests

Updating permissions for Results Job to add content: write to pass to CI_Coverage_compare.

Update CI.yml

Print out the log files created by the testing

Update run_all_tests.py to use python3

Attempt to check if the requirements are installed correctly

github-actions · 2025-03-25T09:59:38Z

Target CPP Coverage: 64.2822%
Source CPP Coverage: 64.2172%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

…github.com/IntelLabs/vdms into feature/276_new_script_file_for_testing_01

github-actions · 2025-03-25T17:48:00Z

Target CPP Coverage: 64.2822%
Source CPP Coverage: 64.2172%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

rolandoquesada · 2025-03-25T20:31:33Z

remote_function/README.md

 python3 -m pip install wheel
 python3 -m pip install -r requirements.txt
-python3 udf_server.py <port_number>
+python3 udf_server.py <port_number> [path_tmp_dir]


@rv355 I would like your opinion about this parameter that I added to the script file, I added it for letting the server know in which directory to create the temporary files.

@rolandoquesada Looks fine to me.

rolandoquesada · 2025-03-25T20:33:23Z

remote_function/README.md

 ```
-2. Download/Copy the `cars.xml` file to the `~/remote_function/functions/files`.
-3. Create the `cardetect.py` file in `~/remote_function/functions`.
+2. Copy the `resources` directory (located at the root of the repo) next to the `remote_function` directory


@rv355 I added this documentation to the README.md file so the user can know that the resources directory (it includes the _haarcascade_frontalface_default.xml file) needs to be copied to the required location.

Cars.xml is used in the example code of the README. Please ensure that the resource files are the same throughout.

Hi @rv355 Please correct me if I am wrong. If Cars.xml file is provided, then the resources folder should not be included as part of the documentation in the README.md file because that folder contains the haarcascade_frontalface_default.xml file which for this case is not needed anymore, am I right?

rv355 · 2025-03-26T06:08:22Z

remote_function/README.md

+5. Now start the remote server at port `5010` and specify the path to the temporary directory where the temporary files will be created (if you don't specify the directory then it will be created in the same path where the udf_server.py file is located at);
 ```
-python3 udf_server.py 5010
+python3 udf_server.py 5010 [path_tmp_dir]


The use of path_tmp_dir should also be mentioned in the Setup section.

….py files" This reverts commit de9a709.

…put video

github-actions · 2025-03-27T08:56:50Z

Target CPP Coverage: 64.2822%
Source CPP Coverage: 64.2172%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

github-actions · 2025-03-27T22:37:22Z

Target CPP Coverage: 64.2822%
Source CPP Coverage: 64.2172%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

rolandoquesada · 2025-03-28T00:18:11Z

I fixed almost all the requested changes to the code, I am going to proceed with updating the wiki according to the suggestions given by @rv355. Thank you.

keirafadams

Only real change/explanation I would at thgis point is the DB pointer in the query handler/server initialization. Other than that, I think we're good to go.

keirafadams · 2025-04-01T20:51:57Z

src/PMGDQueryHandler.cc

  // These parameters can be loaded everytime VDMS is run.
  // We need PMGD to support these as config params before we can do it here.

+  if (_db != nullptr) {


Sorry for the delay, had a lot of unrelated chaos last week.

If its only used in the unit-tests, it does not appear to be causing serious issues. Is there a way to limit the de-allocation to them? My only concern is that we're adding side-effects in a place thats way far away from the proximate causes.

tests/TestScript.py

keirafadams · 2025-04-01T21:11:03Z

tests/run_all_tests.py

Too large to effectively review, hoping functionality is enough to show its doing what its supposed to.

keirafadams · 2025-04-01T21:13:40Z

tests/run_tests.sh


    # Start server for client test
-    ./../build/vdms -cfg unit_tests/config-tests.json > tests_screen.log 2> tests_log.log &
+    ./../build/vdms -cfg /tmp/tests_output_dir/config-tests.json > /tmp/tests_output_dir/tests_screen.log 2> /tmp/tests_output_dir/tests_log.log &


This and below both output to the same log name and location, will this be a problem?

Hi, the original run_tests.sh script file redirected the logs of the different VDMS servers to the same temporary file even when the data was different. I wanted to keep the same approach, however, I could change it to do the logging in different temporary files.
The info is being appended to the same file, so the possible issue is to try to understand which VDMS server logged that information.
@ifadams please let me know if I should keep the logic as it is right now, or if I should change it to log the data to different log files.
Thank you.

Yeah, should probably be different files. Should be a fast fix, however.

We will ignore the log setup for now since this was original behavior. If any issues arise, we can address later

keirafadams · 2025-04-01T21:25:58Z

user_defined_operations/udf_local.py

-socket = context.socket(zmq.REP)
-socket.bind("tcp://*:" + str(settings["port"]))
+# Function to dynamically import a module given its full path
+def import_module_from_path(module_name, path):


@rolandoquesada assuming this has been dealt with?

github-actions · 2025-04-02T08:25:14Z

Target CPP Coverage: 64.2822%
Source CPP Coverage: 64.2075%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

rolandoquesada added 5 commits October 22, 2024 13:42

276 Add new script, fixes to some bugs found and changes to current s…

d2d27d3

…cripts

276 Apply format in Python files

2f019df

276 Fix compilation error when merging the file

7feb16d

Merge branch 'feature/276_new_script_file_for_testing_01' of https://…

9472fff

…github.com/IntelLabs/vdms into feature/276_new_script_file_for_testing_01

276 Update some tests and run_all_tests.py file

88dde27

github-advanced-security bot found potential problems Oct 23, 2024

View reviewed changes

remote_function/udf_server.py Fixed Show fixed Hide fixed

remote_function/udf_server.py Fixed Show fixed Hide fixed

tests/remote_function_test/udf_server.py Fixed Show fixed Hide fixed

rolandoquesada and others added 20 commits October 23, 2024 01:58

276 Fix code scanning alert no. 18

6681c88

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

276 Fix code scanning alert

559b9e1

276 Enabled the option of printing out the log files generated by the…

ac1fa70

… C++ tests

276 Attempt to print out the logs created by the testing process

a7c293e

276 Another attempt to print out the contents of the logs

fa3d680

Merge branch 'develop' into feature/276_new_script_file_for_testing_01

0269c4d

Update CI.yml

03d1c72

Updating permissions for Results Job to add content: write to pass to CI_Coverage_compare.

Merge pull request #242 from IntelLabs/CI-Fix

c5fe9d4

Update CI.yml

276 Add one new line just to trigger the CI/CD process

b75e2e6

Merge branch 'develop' into feature/276_new_script_file_for_testing_01

c8fb9b7

276 Attempt to print out the logs in case of any errors

d1c8429

276 Add new step in the _CI_coverage.yml file

4e49638

Print out the log files created by the testing

276 Attempt to print the logs of the testing

199c599

276 Display the python version

548ac77

Update run_all_tests.py to use python3

276 Add import skvideo.io to the function files

98bf2f8

Merge branch 'develop' into feature/276_new_script_file_for_testing_01

a9646dc

276 Attempt to reload the skvideo module during the testing

5a3b0ee

276 Reload the cv2 library for fixing issue during the testing

0f5e7f5

276 Python 3.12 version used in the run_all_tests.py file

db987b5

Attempt to check if the requirements are installed correctly

276 Attempt to fix the issue related to the mp4 encoder missing

7060ffb

cwlacewe added this to the v2.11.0 Tasks milestone Nov 6, 2024

rolandoquesada added 3 commits November 7, 2024 15:37

276 Show error message in QueryHandler.CustomFunctionNoProcess test

876878f

276 Remove QueryHandler.CustomFunctionNoProcess test

8e00db8

Merge branch 'develop' into feature/276_new_script_file_for_testing_01

263d2d5

github-actions bot and others added 3 commits March 25, 2025 09:59

Automated coverage update

19ee20f

276 Remove hardcoded values for the mocked pids in TestScript.py file

3f6dd8f

Merge branch 'feature/276_new_script_file_for_testing_01' of https://…

4e506d0

…github.com/IntelLabs/vdms into feature/276_new_script_file_for_testing_01

rolandoquesada commented Mar 25, 2025

View reviewed changes

rv355 reviewed Mar 26, 2025

View reviewed changes

rolandoquesada added 4 commits March 25, 2025 23:09

276 Bring back the use of the previous library in the caption.py files

de9a709

276 Fix some wrong paths in one of the CI/CD files

d840731

Revert "276 Bring back the use of the previous library in the caption…

da64dfa

….py files" This reverts commit de9a709.

276 Update the code in caption.py files for using the fps from the in…

0f74054

…put video

276 Update the caption.py files

4cdcf4f

rolandoquesada requested review from cwlacewe, keirafadams and rv355 March 28, 2025 00:16

keirafadams suggested changes Apr 1, 2025

View reviewed changes

This was referenced Apr 2, 2025

Refactor the tests/TestScript.py file #273

Open

Refactor the run_all_tests.py file #274

Open

276 Add missing PMGDQueryHandler::destroy() call in two unit tests

df4d0ce

rolandoquesada requested a review from keirafadams April 2, 2025 07:46

Automated coverage update

70e065b

keirafadams approved these changes Apr 2, 2025

View reviewed changes

cwlacewe approved these changes Apr 2, 2025

View reviewed changes

cwlacewe merged commit 5b6dfe2 into develop Apr 2, 2025
2 checks passed

cwlacewe mentioned this pull request Apr 9, 2025

Orchestration in VDMS with Kubernetes #261

Merged

Conversation

rolandoquesada commented Oct 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rolandoquesada Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rv355 Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

rolandoquesada commented Mar 28, 2025

Uh oh!

keirafadams left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rolandoquesada Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rolandoquesada Mar 25, 2025 •

edited

Loading

rv355 Mar 26, 2025 •

edited

Loading

rolandoquesada Apr 2, 2025 •

edited

Loading