Feature/276 new script file for testing framework #238
Conversation
…github.com/IntelLabs/vdms into feature/276_new_script_file_for_testing_01
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Updating permissions for Results Job to add content: write to pass to CI_Coverage_compare.
Update CI.yml
Print out the log files created by the testing
Update run_all_tests.py to use python3
Attempt to check if the requirements are installed correctly
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
…github.com/IntelLabs/vdms into feature/276_new_script_file_for_testing_01
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
| @@ -38,7 +38,7 @@ source venv/bin/activate | |||
| python3 -m pip install pip --upgrade | |||
| python3 -m pip install wheel | |||
| python3 -m pip install -r requirements.txt | |||
| python3 udf_server.py <port_number> | |||
| python3 udf_server.py <port_number> [path_tmp_dir] | |||
There was a problem hiding this comment.
@rv355 I would like your opinion about this parameter that I added to the script file, I added it for letting the server know in which directory to create the temporary files.
There was a problem hiding this comment.
@rolandoquesada Looks fine to me.
| | |__facedetect.py | ||
| |__README.md | ||
| |__requirements.txt | ||
| |__udf_server.py | ||
| ``` | ||
| 2. Download/Copy the `cars.xml` file to the `~/remote_function/functions/files`. | ||
| 3. Create the `cardetect.py` file in `~/remote_function/functions`. | ||
| 2. Copy the `resources` directory (located at the root of the repo) next to the `remote_function` directory |
There was a problem hiding this comment.
@rv355 I added this documentation to the README.md file so the user can know that the resources directory (it includes the _haarcascade_frontalface_default.xml file) needs to be copied to the required location.
There was a problem hiding this comment.
Cars.xml is used in the example code of the README. Please ensure that the resource files are the same throughout.
There was a problem hiding this comment.
Hi @rv355 Please correct me if I am wrong. If Cars.xml file is provided, then the resources folder should not be included as part of the documentation in the README.md file because that folder contains the haarcascade_frontalface_default.xml file which for this case is not needed anymore, am I right?
| ``` | ||
| python3 udf_server.py 5010 | ||
| python3 udf_server.py 5010 [path_tmp_dir] |
There was a problem hiding this comment.
The use of path_tmp_dir should also be mentioned in the Setup section.
….py files" This reverts commit de9a709.
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
|
I fixed almost all the requested changes to the code, I am going to proceed with updating the wiki according to the suggestions given by @rv355. Thank you. |
| @@ -58,6 +60,10 @@ void PMGDQueryHandler::init() { | |||
| // These parameters can be loaded everytime VDMS is run. | |||
| // We need PMGD to support these as config params before we can do it here. | |||
|
|
|||
| if (_db != nullptr) { | |||
There was a problem hiding this comment.
Sorry for the delay, had a lot of unrelated chaos last week.
If its only used in the unit-tests, it does not appear to be causing serious issues. Is there a way to limit the de-allocation to them? My only concern is that we're adding side-effects in a place thats way far away from the proximate causes.
tests/run_all_tests.py
Outdated
There was a problem hiding this comment.
Too large to effectively review, hoping functionality is enough to show its doing what its supposed to.
|
|
||
| cd .. | ||
|
|
||
| # Start server for client test | ||
| ./../build/vdms -cfg unit_tests/config-tests.json > tests_screen.log 2> tests_log.log & | ||
| ./../build/vdms -cfg /tmp/tests_output_dir/config-tests.json > /tmp/tests_output_dir/tests_screen.log 2> /tmp/tests_output_dir/tests_log.log & |
There was a problem hiding this comment.
This and below both output to the same log name and location, will this be a problem?
There was a problem hiding this comment.
Hi, the original run_tests.sh script file redirected the logs of the different VDMS servers to the same temporary file even when the data was different. I wanted to keep the same approach, however, I could change it to do the logging in different temporary files.
The info is being appended to the same file, so the possible issue is to try to understand which VDMS server logged that information.
@ifadams please let me know if I should keep the logic as it is right now, or if I should change it to log the data to different log files.
Thank you.
There was a problem hiding this comment.
Yeah, should probably be different files. Should be a fast fix, however.
There was a problem hiding this comment.
We will ignore the log setup for now since this was original behavior. If any issues arise, we can address later
| socket = context.socket(zmq.REP) | ||
| socket.bind("tcp://*:" + str(settings["port"])) | ||
| # Function to dynamically import a module given its full path | ||
| def import_module_from_path(module_name, path): |
There was a problem hiding this comment.
@rolandoquesada assuming this has been dealt with?
|
Target CPP Coverage: 64.2822% Target Python Coverage: 97.94% |
No description provided.