Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(process marker) #141

Merged
merged 18 commits into from
May 3, 2024
Merged

refactor(process marker) #141

merged 18 commits into from
May 3, 2024

Conversation

Ipuch
Copy link
Owner

@Ipuch Ipuch commented May 2, 2024

done


This change is Reviewable

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 97.48744% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 83.98%. Comparing base (a7cba88) to head (9d9825f).
Report is 1 commits behind head on main.

Files Patch % Lines
bionc/bionc_casadi/biomechanical_model_markers.py 40.00% 3 Missing ⚠️
bionc/utils/markers_check_import.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   83.67%   83.98%   +0.31%     
==========================================
  Files          93       96       +3     
  Lines        5984     6119     +135     
==========================================
+ Hits         5007     5139     +132     
- Misses        977      980       +3     
Flag Coverage Δ
unittests 83.98% <97.48%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ipuch
Copy link
Owner Author

Ipuch commented May 2, 2024

@aaiaueil Let me know if the new attributes in ik.sol helps you, I still need to implement some tests and we are good I believe. I detailed everything in doc strings for the format of the output 3d, 2d confidence, and overall confidence !

I got some knots in heads to unpack some functions, but tests are intact, meaning I was doing it right :)

Copy link

codeclimate bot commented May 3, 2024

Code Climate has analyzed commit 9d9825f and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2

View more on Code Climate.

@Ipuch Ipuch merged commit cc6e5c3 into main May 3, 2024
6 of 7 checks passed
@Ipuch Ipuch deleted the ik branch May 3, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant