Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inserting new entry #12123

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix inserting new entry #12123

merged 1 commit into from
Oct 29, 2024

Conversation

LoayGhreeb
Copy link
Collaborator

New entries were not correctly bound to the entry editor and main table because they were cloned before being added to the database.

Follow-up to #11724.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/656

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Copy link
Contributor

github-actions bot commented Oct 29, 2024

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor
Copy link
Member

koppor commented Oct 29, 2024

Check with copy and paste between libraries!

@LoayGhreeb
Copy link
Collaborator Author

Check with copy and paste between libraries!

Tested and working!

@calixtus
Copy link
Member

I have no idea what the reasoning was for cloning the entries. @tobiasdiez do you remember?

@LoayGhreeb
Copy link
Collaborator Author

The clone added in #11915

@koppor
Copy link
Member

koppor commented Oct 29, 2024

The clone added in #11915

OK, then we merge and check the citation relation tab code later. When looking on it on the mobile phone, chances are high that the result of the merge entries dialog is a new Obect.

@koppor koppor added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 108a6d1 Oct 29, 2024
26 checks passed
@koppor koppor deleted the fix-new-entry branch October 29, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants