Merged
Conversation
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
approved these changes
Oct 29, 2024
Member
|
Check with copy and paste between libraries! |
Member
Author
Tested and working! |
Member
|
I have no idea what the reasoning was for cloning the entries. @tobiasdiez do you remember? |
Member
Author
|
The clone added in #11915 |
Member
OK, then we merge and check the citation relation tab code later. When looking on it on the mobile phone, chances are high that the result of the merge entries dialog is a new Obect. |
koppor
approved these changes
Oct 29, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New entries were not correctly bound to the entry editor and main table because they were cloned before being added to the database.
Follow-up to #11724.
Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/656
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)