Fix for python 3.8 #125
Closed
Fix for python 3.8 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesus2099
reviewed
Mar 1, 2021
| @@ -43,6 +43,8 @@ | |||
| from optparse import OptionParser | |||
| from subprocess import Popen, PIPE, call | |||
|
|
|||
| os.add_dll_directory(os.getcwd()) | |||
There was a problem hiding this comment.
I am in Python 64-bit v3.7.4 in Windows 10, this row throws following error and prevents isrcsubmit from running:
AttributeError: module 'os' has no attribute 'add_dll_directory'
What could we do to fix script for version 3.8 without breaking older versions?
There was a problem hiding this comment.
Same error with Python 32-bit v3.4.3 in Windows XP.
(both setups are running fine without this line)
|
No response from submitter in over a year. Going to close this. I’ll keep the issue open though and may look into a way to fix this. Thanks for the PR! |
This was referenced Mar 26, 2023
|
I found a way to run this fix only in Windows Python 3.8+, only when it is both required and non-breaking: #144. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here: https://stackoverflow.com/questions/59014318/filenotfounderror-could-not-find-module-libvlc-dll