Windows Python 3.8+: Search current folder for discid.dll

[jesus2099]

Fixes #143 (Windows Python 3.8+ Could not find module 'discid.dll'), without tampering with other setups.

This #125 fix from @omgitsraven was NG for Python 3.7 and less, while OK for Python 3.8+.
I found how to test Python version with https://stackoverflow.com/a/3016198/2236179 and I also test if script is running in Windows.

Tested on Linux (condition not met, do the script runs good as usual) and Windows Python 3.10.1 (condition met, fixes #143 and now the script is running good).
The script works in both cases.

I no longer have old python version but I have tested my version condition and it should work to prevent the new line in python 3.7 and earlier.

Then something must be done to bump version number and to publish new version zip files.

PATCH

If you want to test in your environment, the patch is to insert the following code, before the first try of the script:

# Windows Python 3.8+ scan current folder for discid.dll
if os.name == "nt" and sys.version_info >= (3,8):
    os.add_dll_directory(os.getcwd())

TEST

OS	Python	2.1.1-beta	Patched 2.1.1-beta	3.0.0-dev	Patched 3.0.0-dev
Debian 11 64 bits	3.9.2	👍	👍	👍	👍
Windows XP 32 bits	3.4.3	👍	👍	👍	👍
Windows 11 64 bits	3.10.7	❌	👍	❌	👍

[jesus2099]

The failed check is the same PyPy3 check that failed with all previous pull requests:

Error: PyPy 3.6 not found

[jesus2099]

Tested successfully on:

• Debian GNU/Linux 11 64 bits Python 3.9.2 👍 condition not met, add_dll_directory not run: not supported and not needed
• Windows XP 2002 SP3 32 bits Python 3.4.3 👍 condition not met, add_dll_directory not run: not supported and not needed
• Windows 11 64 bits Python 3.10.7 👍 condition met, add_dll_directory run: supported and required

[jesus2099]

I put this in draft, leaving some time for the discussion to take place a little bit.

And I want to try git magic to queue my IF change behind @omgitsraven change and also I forgot to bump the version up to 2.2 or 2.1.2.

[jesus2099]

I managed to include original bug fix author in the PR.
I found out about version 3.0.0-dev that does include 2.1.1-beta changes in main branch, so I tested this one patched on Windows Python 3.8+ and it's OK.

[jesus2099]

I tested 3.0.0-dev and patched 3.0.0-dev on my 2 other environments as well now.
All good.

[jesus2099]

I leave you manage the version change, if needed.

[kellnerd]

I can confirm that this patch works as expected with Windows 10 Pro 64 bit, Python 3.12 and isrcsubmit 2.1.0 (I think I already replaced discid.dll with a 64 bit version a few years ago).

[jesus2099]

Thank you for testing successfully!

I already replaced discid.dll with a 64 bit version

Maybe that #127 PR?
But I'm not sure if the downloads are updated, except in isrcsubmit-2.1.1-beta-win64.zip, in hidden downloads listing.