Skip to content
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "LazyArrays"
uuid = "5078a376-72f3-5289-bfd5-ec5146d43c02"
version = "2.9"
version = "2.9.1"

[deps]
ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
Expand Down
8 changes: 7 additions & 1 deletion src/cache.jl
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ cache_layout(::AbstractStridedLayout, O::AbstractArray) = copy(O)

const _cache = cache_layout # TODO: deprecate
cacheddata(A::AbstractCachedArray) = view(A.data,OneTo.(A.datasize)...)
cacheddata(A::Adjoint{<:Any, <:AbstractCachedArray}) = adjoint(cacheddata(parent(A)))
cacheddata(A::Transpose{<:Any, <:AbstractCachedArray}) = transpose(cacheddata(parent(A)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no reason to assume the parent is an AbstractCachedArray (it could just conform to the cached array interface):

Suggested change
cacheddata(A::Transpose{<:Any, <:AbstractCachedArray}) = transpose(cacheddata(parent(A)))
cacheddata(A::Adjoint) = adjoint(cacheddata(parent(A)))
cacheddata(A::Transpose) = transpose(cacheddata(parent(A)))


maybe_cacheddata(A::AbstractCachedArray) = cacheddata(A)
maybe_cacheddata(A::SubArray{<:Any,N,<:AbstractCachedArray}) where N = cacheddata(A)
Expand Down Expand Up @@ -333,6 +335,9 @@ MemoryLayout(C::Type{CachedArray{T,N,DAT,ARR}}) where {T,N,DAT,ARR} = cachedlayo

MemoryLayout(::Type{<:AbstractCachedArray}) = GenericCachedLayout()

transposelayout(::GenericCachedLayout) = GenericCachedLayout()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:

Suggested change
transposelayout(::GenericCachedLayout) = GenericCachedLayout()
transposelayout(::AbstractCachedLayout) = GenericCachedLayout()

(also next line)

conjlayout(::Type{<:Complex}, ::GenericCachedLayout) = GenericCachedLayout()

#####
# broadcasting
#
Expand All @@ -345,10 +350,11 @@ CachedArrayStyle(::Val{N}) where N = CachedArrayStyle{N}()
CachedArrayStyle{M}(::Val{N}) where {N,M} = CachedArrayStyle{N}()

BroadcastStyle(::Type{<:AbstractCachedArray{<:Any,N}}) where N = CachedArrayStyle{N}()
BroadcastStyle(::Type{<:AdjOrTrans{<:Any, <:AbstractCachedArray{<:Any,N}}}) where N = CachedArrayStyle{N}()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to support adjoints of views of cached arrays?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that comes up but I can add support for it anyway

BroadcastStyle(::Type{<:SubArray{<:Any,N,<:AbstractCachedArray{<:Any,M}}}) where {N,M} = CachedArrayStyle{M}()
BroadcastStyle(::Type{<:SubArray{<:Any,N,<:AdjOrTrans{<:Any, <:AbstractCachedArray{<:Any,M}}}}) where {N,M} = CachedArrayStyle{M}()
BroadcastStyle(::CachedArrayStyle{N}, ::LazyArrayStyle{M}) where {N,M} = CachedArrayStyle{max(M, N)}()


broadcasted(::AbstractLazyArrayStyle, op, A::CachedArray) = CachedArray(broadcast(op, cacheddata(A)), broadcast(op, A.array))
layout_broadcasted(::CachedLayout, _, op, A::AbstractArray, c::Number) = CachedArray(broadcast(op, cacheddata(A), c), broadcast(op, A.array, c))
layout_broadcasted(_, ::CachedLayout, op, c::Number, A::CachedArray) = CachedArray(broadcast(op, c, cacheddata(A)), broadcast(op, c, A.array))
Expand Down
19 changes: 18 additions & 1 deletion test/cachetests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ using LazyArrays, FillArrays, LinearAlgebra, ArrayLayouts, SparseArrays, Test
using StaticArrays
import LazyArrays: CachedArray, CachedMatrix, CachedVector, PaddedLayout, CachedLayout, resizedata!, zero!,
CachedAbstractArray, CachedAbstractVector, CachedAbstractMatrix, AbstractCachedArray, AbstractCachedMatrix,
PaddedColumns, cacheddata, maybe_cacheddata
PaddedColumns, cacheddata, maybe_cacheddata, Accumulate, CachedArrayStyle, GenericCachedLayout

using ..InfiniteArrays
using .InfiniteArrays: OneToInf
Expand Down Expand Up @@ -539,6 +539,23 @@ using Infinities
C = [1, 2, 3]
@test maybe_cacheddata(C) === C
end

@testset "Missing BroadcastStyles/MemoryLayouts/cacheddata with CachedArrayStyles" begin
A = view(Accumulate(*, [1, 2, 3])', 1:1, 1:2)
B = view(transpose(Accumulate(*, [1, 2im, 3])), 1:1, 1:2)
C = Accumulate(*, [1, 2im, 3])'
D = transpose(Accumulate(*, [1, 2im, 3]))
E = view(Accumulate(*, [1, 2im, 3])', 1:1, 1:2)
@test all(==(CachedArrayStyle{1}()), Base.BroadcastStyle.(typeof.((A, B, C, D, E))))
@test all(==(GenericCachedLayout()), MemoryLayout.(typeof.((A, B, E))))
@test MemoryLayout(typeof(C)) == DualLayout{GenericCachedLayout}()
@test MemoryLayout(typeof(D)) == DualLayout{GenericCachedLayout}()
@test cacheddata(A) === view(cacheddata(parent(parent(A)))', 1:1, 1:1)
@test cacheddata(B) === view(transpose(cacheddata(parent(parent(B)))), 1:1, 1:1)
@test cacheddata(C) === cacheddata(parent(C))'
@test cacheddata(D) === transpose(cacheddata(parent(D)))
@test cacheddata(E) === view(cacheddata(parent(parent(E)))', 1:1, 1:1)
end
end

end # module
Loading