refactor: update for MTKv9 #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note to self, bump major version of this package before release |
|
If you want to retain MTKv8 compatibility, something like this should do it: const unknowns = isdefined(ModelingToolkit.states) ? ModelingToolkit.states : ModelingToolkit.unknownsShould I add it in or is dropping v8 fine? |
|
Dropping v8 is fine, I've found that trying to support multiple versions at the same time is a headache and a source of lots of wasted time and energy anyways |
5 tasks
|
superseeded by #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.