fix INT128_MIN write #1152
Merged
fix INT128_MIN write #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 90.47% 89.99% -0.48%
==========================================
Files 9 8 -1
Lines 2319 2288 -31
==========================================
- Hits 2098 2059 -39
- Misses 221 229 +8 ☔ View full report in Codecov by Sentry. |
nhz2
reviewed
Jan 3, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Nathan Zimmerberg <[email protected]>
nhz2
reviewed
Jan 6, 2025
Comment on lines
199
to
204
| # 1151 | ||
| ( | ||
| [(a=Int128(-170141183460469231731687303715884105728),)], | ||
| NamedTuple(), | ||
| "a\n-170141183460469231731687303715884105728\n" | ||
| ) |
Contributor
There was a problem hiding this comment.
It would be good to add a test with BigInt as well to avoid future regressions.
nhz2
approved these changes
Jan 9, 2025
Contributor
nhz2
left a comment
nhz2
left a comment
There was a problem hiding this comment.
Thank you for fixing this. I did a basic benchmark with:
using BenchmarkTools, CSV
@btime CSV.writecell($(zeros(UInt8,1000)), 1, 100, $(IOBuffer()), -1234567890, nothing)And I don't see a major performance regression, so I think this is ready to be merged.
quinnj
approved these changes
Jan 10, 2025
Member
quinnj
left a comment
quinnj
left a comment
There was a problem hiding this comment.
Thanks! Sorry for hte slow review.
quinnj
pushed a commit
that referenced
this pull request
Jan 12, 2026
* fix INT128_MIN write * add write INT128_MIN test * use Base.uabs Co-authored-by: Nathan Zimmerberg <[email protected]> * add BigInt test --------- Co-authored-by: Nathan Zimmerberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #1151