Skip to content

fix INT128_MIN write #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quinnj merged 4 commits into from
Jan 10, 2025
Merged

fix INT128_MIN write #1152

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecc77e2
fix INT128_MIN write
belous-dp Dec 18, 2024
1c1ce1e
add write INT128_MIN test
belous-dp Dec 18, 2024
636e202
use Base.uabs
belous-dp Jan 6, 2025
39a57a4
add BigInt test
belous-dp Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/write.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ end

function writecell(buf, pos, len, io, x::Integer, opts)
if x < 0
x *= -1
x = Base.uabs(x)
@check 1
@inbounds buf[pos] = UInt8('-')
pos += 1
Expand Down
6 changes: 6 additions & 0 deletions test/write.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,12 @@ Base.string(x::AF) = string(x.f)
[StructType(Date("2021-12-01"), "string 1", 123.45), StructType(Date("2021-12-02"), "string 2", 456.78)],
(header=["Date Column", "String Column", "Number Column"],),
"Date Column,String Column,Number Column\n2021-12-01,string 1,123.45\n2021-12-02,string 2,456.78\n"
),
# 1151
(
[(a=Int128(-170141183460469231731687303715884105728),)],
NamedTuple(),
"a\n-170141183460469231731687303715884105728\n"
)
Copy link
Contributor

@nhz2 nhz2 Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a test with BigInt as well to avoid future regressions.

Copy link
Contributor Author

@belous-dp belous-dp Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

]

Expand Down
Loading