-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linalg
dialect bindings are incomplete #54
#55
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
=====================================
Coverage 3.24% 3.24%
=====================================
Files 107 107
Lines 26059 26059
=====================================
Hits 845 845
Misses 25214 25214 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
Another dialect with (a lot) of different tablegen files is transform
. https://mlir.llvm.org/docs/Dialects/Transform/
I copied the output for transform ops of structured linalg manually before (https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td) when I needed those, but it would be nice to have the transform ops for all dialects available.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If mlir-jl-tblgen
supports the ops in transform
, then it should be doable. Let me see what files are required and I will add them.
Fixes #54
We need to rerun the binding generation with this PR.