Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linalg dialect bindings are incomplete #54 #55

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Fix linalg dialect bindings are incomplete #54 #55

merged 6 commits into from
Feb 15, 2024

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Feb 7, 2024

Fixes #54

We need to rerun the binding generation with this PR.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b065747) 3.24% compared to head (bc24f7b) 3.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #55   +/-   ##
=====================================
  Coverage   3.24%   3.24%           
=====================================
  Files        107     107           
  Lines      26059   26059           
=====================================
  Hits         845     845           
  Misses     25214   25214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy mentioned this pull request Feb 7, 2024
Copy link
Collaborator

@jumerckx jumerckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.
Another dialect with (a lot) of different tablegen files is transform. https://mlir.llvm.org/docs/Dialects/Transform/
I copied the output for transform ops of structured linalg manually before (https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Dialect/Linalg/TransformOps/LinalgTransformOps.td) when I needed those, but it would be nice to have the transform ops for all dialects available.
What do you think?

Copy link
Member Author

@mofeing mofeing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If mlir-jl-tblgen supports the ops in transform, then it should be doable. Let me see what files are required and I will add them.

@mofeing mofeing merged commit c475938 into JuliaLLVM:main Feb 15, 2024
4 checks passed
@mofeing mofeing deleted the fix-multi-td-dialects branch February 15, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linalg dialect bindings are incomplete
3 participants