-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doctest #1199
base: master
Are you sure you want to change the base?
Fix doctest #1199
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 34 34
Lines 15365 15365
=======================================
Hits 14115 14115
Misses 1250 1250 ☔ View full report in Codecov by Sentry. |
@@ -65,7 +65,7 @@ julia> C.U | |||
⋅ ⋅ 3.0 | |||
|
|||
julia> C.L | |||
3×3 LowerTriangular{Float64, Adjoint{Matrix{Float64}}}: | |||
3×3 LowerTriangular{Float64, {Matrix{Float64}}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right, or? Maybe
3×3 LowerTriangular{Float64, {Matrix{Float64}}: | |
3×3 LowerTriangular{Float64, Matrix{Float64}}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There must be a mismatch between used code and tests in the failing doctest. This has been changed deliberately lately IIRC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess is that the docs don't run with the custom sysimage and are in fact testing the bundled LinearAlgebra. Could that be correct?
Can someone look at https://buildkite.com/julialang/julia-master/builds/44616#0194f191-ee57-4a81-ab55-0192700d1df9/823-1641? I don't see why Adjoint is in the output for LowerTriangular in the CI, both before and after:
None of this got caught in the CI in this repo - and at least in my local build on |
Fix doctest seen in:
https://buildkite.com/julialang/julia-master/builds/44616#0194f191-ee57-4a81-ab55-0192700d1df9