Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for loongarch64 #479

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Add support for loongarch64 #479

merged 1 commit into from
Oct 21, 2024

Conversation

qiangxuhui
Copy link
Contributor

Fix build on linux/loongarch64.

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rpavlik
Copy link
Contributor

rpavlik commented Jun 4, 2024

We will need you to sign the CLA. In addition, this should be added to the table in the loader design doc alongside the rest of the platforms.

Also, we tend to follow Debian, who uses loong64 as the architecture name: https://wiki.debian.org/Ports/loong64

@Perksey
Copy link

Perksey commented Jun 4, 2024

I don't think Loongson can sign a Khronos Group agreement due to U.S. sanctions.

@qiangxuhui
Copy link
Contributor Author

@rpavlik PTAL.

@utzcoz
Copy link
Contributor

utzcoz commented Jun 5, 2024

@qiangxuhui I think you need a separate commit for change fragment. You can check other merged PRs on GitHub to see what it means.

@qiangxuhui
Copy link
Contributor Author

@utzcoz Done.

@rpavlik-bot
Copy link
Collaborator

An issue (number 2306) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2306 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Jun 8, 2024
@rpavlik rpavlik self-requested a review September 23, 2024 15:46
rpavlik
rpavlik requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@rpavlik rpavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name looks good, matches Debian. Just one question about the specific ABI, and then I'll request working group approval to merge.

@stdmnpkg stdmnpkg mentioned this pull request Oct 5, 2024
Open
wszqkzqk added a commit to wszqkzqk/loongarch-packages that referenced this pull request Oct 8, 2024
@wszqkzqk
addpatch: openxr, ver=1.0.28-1
1a868b0 
* Fix from [OpenXR-SDK-Source#479](KhronosGroup/OpenXR-SDK-Source#479)

Signed-off-by: Zhou Qiankang <[email protected]>
@wszqkzqk wszqkzqk mentioned this pull request Oct 8, 2024
Merged
wszqkzqk added a commit to lcpu-club/loongarch-packages that referenced this pull request Oct 8, 2024
@wszqkzqk
addpatch: openxr, ver=1.0.28-1 (#140)
070c6e3 
* Temporary fix from
[OpenXR-SDK-Source#479](KhronosGroup/OpenXR-SDK-Source#479)

Signed-off-by: Zhou Qiankang <[email protected]>
@qiangxuhui
Copy link
Contributor Author

@rpavlik Done.

rpavlik
rpavlik approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@rpavlik rpavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@qiangxuhui @rpavlik
Add support for loongarch64
dfdf0fe 
Fix build on linux/loongarch64.

Add loong64's info to loader doc

Changelog fragment

Fix the description of loong64 in specification/loader/runtime.adoc
@rpavlik rpavlik enabled auto-merge (rebase) October 21, 2024 16:20
@rpavlik rpavlik merged commit 1284d2a into KhronosGroup:main Oct 21, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpavlik rpavlik rpavlik approved these changes

Assignees
No one assigned
Labels
synced to gitlab Synchronized to OpenXR internal GitLab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qiangxuhui @CLAassistant @rpavlik @Perksey @utzcoz @rpavlik-bot