Cleanups for utilities #254
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is somewhat experimental (maybe not to be merged). It addresses #252 and (to some extent) #253 .
The first commit is only formatting. (I just picked the first PHP formatter that I found. I think that automatic formatting can be important, but don't give a ... care about what the exact formatting is).
The next commits are fixing the typos from #252
Two commits are for some minor formatting of the license texts, and ee82cb7 adds a text to the "Stanford" license file, which until now, only contained
"See the page on ...tbd."
But... I think that this file is not actually used. Maybe it could simply be removed (similarly for some other files in the LICENSES folder)
In the last commit, I tried to fix the license links that didn't lead anywhere, but should have led to the LICENSES folder. There, I stumbled a bit. I'll have to read the PHP more thoroughly (and in the course of that, I'd probably add comments!!!). It looks like there are two ways about how this can be run, and one of them inserts some
licenseUrlinto themetadata.json, unless thatlicenseUrlwas already there. Even without a deeper understanding of what the PHP is doing exactly: I think that it should NOT modify themetadata.json, ever. This is supposed to be pure input. It can be checked and validated and the CI can fail when it's not complete and whatnot. But it should NOT be modified by CI.