-
Notifications
You must be signed in to change notification settings - Fork 712
Conversation
c970b22
to
380f38c
Compare
380f38c
to
8ae96f3
Compare
I split the libs because we have 200+ footprints with the new additions, and since on the KLC a limit of 250 is stated i assumed it was a hard requirement. But when i was looking at the issues i found this:
Originally posted by @SchrodingersGat in #544 (comment) Since it's apparently not that big of a deal, maybe it's not necessary to split them. |
250 is not a hard limit, but splitting by manufacturer may still be a good idea. That being said, upstreaming these footprints is a great idea, Edit: Never mind, I didn't read your original comment carefully enough. |
@chschlue It is independent from that PR, though they add compatibility for the same kind of components, with slight differences: |
Can we split this PR please? How about one PR per manufacturer, perhaps even split by series. |
I'll split it tonight |
Split into several PRs and a central discussion issue. |
This PR aims at reworking the current footprints related to keyboard switches, as well as it's structure, as in, directories.
It adds footprints for Cherry MX keyswitches, Alps / Matias keyswitches, Kailh Choc keyswitches and Kailh hotswap sockets for the Cherry MX format.
It Overrides the existing footprints, but they are mostly the same.
These footprints come from a repository that has been widely used by the community, and is generally used as opposed to the official libraries, given it's limited amount of footprints. They have suffered quite a bit of modification to better comply with KLC and fit with the rest of the official libraries.
Due to the high amount of footprints added i felt it was necessary to split the original Button_Switch_Button_Keyboard.pretty into:
There is some KLC breakage, but it's mostly on purpose:
Given the nature of these components it is extremely convenient to have their origin at the center, and i feel it's justified.
It is typical for keyboard switch footprint to not have mask on the switch side, ie, the solder mask is supposed to cover the pads on the side the switch is placed on.
F7.3 and F9.3 are just warnings and should not be an issue.
Reference for Alps/Matias keyswitches
Reference for Cherry MX keyswitches
Reference for Kailh Choc keyswitches
Reference for Kailh Hotswap Socket
I am aware that this conflicts with a current PR #2389 Though I am submitting some footprints that directly conflict with those, they can still be merged given they are a slightly different implementation that may be of interest.
I'm sorry for the big PR/submission, I tried my best to have a clean set of footprints so that this process may go smoothly.