Skip to content

Conversation

@kangaroomadman
Copy link
Contributor

Specify levelReportingConfig for Candeo C202.1 device. This matches the configuration from other Candeo devices. e.g. C201/C202/C203/C204

extend: [
m.light({
configureReporting: true,
levelReportingConfig: {min: 1, max: 3600, change: 1},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
levelReportingConfig: {min: 1, max: 3600, change: 1},
levelReportingConfig: true,

can you try with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't levelReportingConfig be an object that overwrites the defaults using the spread operator?

{attribute: "currentLevel", min: "5_SECONDS", max: "MAX", change: 1, ...(levelReportingConfig || {})},

The reporting is already configured for this device, but the default minimum of 5 seconds is quite high so the main purpose of this change is to bring this down to 1 second.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to change the default instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can do that. Just to check, that's change the light default in modernExtend? Should I also drop any overrides that are currently set to that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants