Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/devices/candeo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,13 @@ export const definitions: DefinitionWithExtend[] = [
model: "C202.1",
vendor: "Candeo",
description: "Zigbee LED smart dimmer switch",
extend: [m.light({configureReporting: true, powerOnBehavior: false})],
extend: [
m.light({
configureReporting: true,
levelReportingConfig: {min: 1, max: 3600, change: 1},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
levelReportingConfig: {min: 1, max: 3600, change: 1},
levelReportingConfig: true,

can you try with this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't levelReportingConfig be an object that overwrites the defaults using the spread operator?

{attribute: "currentLevel", min: "5_SECONDS", max: "MAX", change: 1, ...(levelReportingConfig || {})},

The reporting is already configured for this device, but the default minimum of 5 seconds is quite high so the main purpose of this change is to bring this down to 1 second.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose to change the default instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can do that. Just to check, that's change the light default in modernExtend? Should I also drop any overrides that are currently set to that?

powerOnBehavior: false,
}),
],
},
{
fingerprint: [
Expand Down
Loading