Add Qt6 Support #7339

tresf · 2024-06-22T19:58:57Z

Resolves #6614.

messmerd · 2024-10-23T19:34:33Z

I successfully built LMMS with Qt 6.8.0 on Linux without the Core5Compat module.

When compiling, there were a number of deprecation warnings unrelated to that change that we should probably address in this PR.

tresf · 2025-02-09T04:51:41Z

When compiling, there were a number of deprecation warnings unrelated to that change that we should probably address in this PR.

I'm wondering if we should put our efforts into fixing merge conflicts with the qt6 branch and getting it merged before the codebase diverts further? I also believe that we should have at least one automated build to ensure new features added don't cause compilation errors for future qt6 efforts.

messmerd · 2025-02-09T05:06:49Z

@tresf I'd be fine with that.

Maybe Windows MSVC could be our Qt 6 build in the CI since it wouldn't be hard to update the dependency to Qt 6, and the MinGW build is still available in case any issues arise with it. We could do it in this PR after fixing the merge conflicts.

src/core/AutomationClip.cpp

src/gui/clips/AutomationClipView.cpp

tresf · 2025-02-18T22:43:40Z

@tresf I'd be fine with that.

Maybe Windows MSVC could be our Qt 6 build in the CI since it wouldn't be hard to update the dependency to Qt 6, and the MinGW build is still available in case any issues arise with it. We could do it in this PR after fixing the merge conflicts.

Merge conflicts fixed. Some touched lines don't appear to be related to this PR I've started a conversation thread on these files, please mark as resolved if they're warranted.

The history is a bit weird (as most rebases are) and I made plenty of mistakes merging, but the branch should be in pretty good shape right now. I think it's ready for a CI job to run against Qt6 as well as a few set of eyes particularly from those that have helped with the code leading up to this point.

Please push patches directly to this branch.

plugins/ZynAddSubFx/CMakeLists.txt

Co-authored-by: michaelgregorius <[email protected]> Co-authored-by: Rossmaxx <[email protected]>

- Fix linking issues with Qt Framework files - Fix qmake detection

Fix implicit conversion from int when using QString.arg(...)

* Adds win32EventFilter a wrapper for nativeEventFilter on Windows * win32EventFilter is currently used to intercept top-level Window events (currently, to avoid VSTs setting transparency of the parent application)

QComboBox activated() replaced with textActivated() since Qt 5.14

* enabled VST support for Qt 6 builds * Note : Embedding on QT6 will be buggy on linux as a result of using qt embedding, which unfortunately is a qt bug which hasn't been resolved.

* Added lines in between bars * Changed bar lines to follow snap size * Changed default zoom and quantization value * Added constants for line widths * Added QSS configuration for new grid line colors * Tied line widths to QSS properties * Changed default quantization to 1/4 * Removed clear() from destructor model * Removed destructor in ComboBoxModel.h * Changed member set/get functions to pass by value * Updated signal connection with newer syntax

* ensured mouse event != nullptr before deref * separation of concerns: AFP WaveView updateCursor extract check to pointerCloseToStartEndOrLoop() * marked some function parameters as const

.gitmodules

tresf · 2025-03-31T15:30:48Z

@messmerd any luck fixing msvc?

Conflicts: AutomationClipView.cpp ClipView.cpp TrackContentWidget.cpp

messmerd · 2025-07-10T19:59:46Z

Looks like updating from Qt 6.5 to Qt 6.8 fixed ZynAddSubFX's zlib linkage issue on MSVC. 🎉
I guess it was an upstream issue that they fixed.

I also got Qt6 builds working locally on my Linux machine, though there are still a couple deprecation warnings that I want to try fixing.

Some comparisons were using ">" rather than ">="

Conflicts: - src/gui/MainWindow.cpp

The Qt bug that used to be present appears to have been fixed, so the workaround can be removed

messmerd

Just making note of two places where I'm not sure why a change was made.

The rest of the changes made in this PR I have reviewed and understand.

messmerd · 2025-07-11T00:46:08Z

include/ControlLayout.h

+#if (QT_VERSION >= QT_VERSION_CHECK(6, 0, 0))
+	using ControlLayoutMap = QMultiMap<QString, QLayoutItem*>;
+	using ControlLayoutMapIterator = QMultiMapIterator<QString, QLayoutItem*>;
+#else
+	using ControlLayoutMap = QMap<QString, QLayoutItem*>;
+	using ControlLayoutMapIterator = QMapIterator<QString, QLayoutItem*>;
+#endif
+


Not sure why this was done

messmerd · 2025-07-11T00:46:47Z

src/gui/tracks/TrackView.cpp

+			QCursor::setPos(mapToGlobal(QPoint(pos.x(), height())));
+			QApplication::setOverrideCursor(Qt::SizeVerCursor);
+		}
+		else
+		{
+			if (pos.x() > 10) // 10 = The width of the grip + 2 pixels to the left and right.
+			{
+				QWidget::mousePressEvent(me);
+				return;
+			}
+
+			m_action = Action::Move;
+			QApplication::setOverrideCursor(Qt::SizeVerCursor);
+
+			// update because in move-mode, all elements in
+			// track-op-widgets are hidden as a visual feedback
+			m_trackOperationsWidget.update();


Also not sure why this was done

messmerd · 2025-07-11T00:58:47Z

This PR is functionally complete and ready for review and testing.

Testing instructions

Test the GUI on the Windows MSVC build to see if there are any regressions in how things appear or in interactions with GUI elements. If you find a bug that is also present in Windows MSVC on nightly, that's okay since it wasn't caused by this PR.

For now, only Windows MSVC is using Qt6 and rest of the builds remain on Qt5. The Qt5 builds should behave the same as before this PR unless an egregious mistake was made in the deprecation helpers or elsewhere, so a quick check of the Qt5 builds might be a good idea.

JohannesLorenz added this to the 1.3 milestone Aug 4, 2024

tresf mentioned this pull request Dec 5, 2024

Defining an MSYS2 build command list #7526

Closed

1 task

tresf mentioned this pull request Feb 10, 2025

Improve Qt5 detection on macOS #7699

Merged

tresf force-pushed the qt6 branch from 9de3f3b to 8db07be Compare February 18, 2025 22:11

tresf commented Feb 18, 2025

View reviewed changes

src/core/AutomationClip.cpp Show resolved Hide resolved

tresf commented Feb 18, 2025

View reviewed changes

src/gui/clips/AutomationClipView.cpp Outdated Show resolved Hide resolved

tresf mentioned this pull request Feb 18, 2025

Add Qt 6 support #6614

Open

26 tasks

messmerd reviewed Feb 21, 2025

View reviewed changes

plugins/ZynAddSubFx/CMakeLists.txt Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as outdated.

Sign in to view

This comment was marked as off-topic.

Sign in to view

tresf and others added 12 commits February 22, 2025 19:28

Rebase against master

124113e

Co-authored-by: michaelgregorius <[email protected]> Co-authored-by: Rossmaxx <[email protected]>

Fix Qt6 DMG on Apple (#7240)

9e07736

- Fix linking issues with Qt Framework files - Fix qmake detection

Fixes after rebase

1afd5d5

Fix embed.cpp compilation

1d6338a

Fix implicit conversion from int when using QString.arg(...)

Fix Qt6 signature change for nativeEventFilter (#7254)

b1f0ace

* Adds win32EventFilter a wrapper for nativeEventFilter on Windows * win32EventFilter is currently used to intercept top-level Window events (currently, to avoid VSTs setting transparency of the parent application)

fix broken signal slot connections (#7274)

8dd521a

QComboBox activated() replaced with textActivated() since Qt 5.14

Enabled VSTs on Qt 6 (#7273)

5471ab1

* enabled VST support for Qt 6 builds * Note : Embedding on QT6 will be buggy on linux as a result of using qt embedding, which unfortunately is a qt bug which hasn't been resolved.

Fix compilation

c55f76c

Fix MSVC builds

1497298

fix nullptr deref in AudioFileProcessor (qt6 branch) (#7532)

045a059

* ensured mouse event != nullptr before deref * separation of concerns: AFP WaveView updateCursor extract check to pointerCloseToStartEndOrLoop() * marked some function parameters as const

Remove Core5Compat usage

5a1b745

tresf added 2 commits February 24, 2025 01:30

Fix vertical & horizontal scroll wheel in SongEditor

10632b3

AppImage: Fix finding of Qt6 libs

3bf6805

tresf commented Feb 24, 2025

View reviewed changes

.gitmodules Outdated Show resolved Hide resolved

tresf mentioned this pull request Feb 24, 2025

MSVC: Always use Win32 ANSI functions LMMS/veal#14

Closed

tresf added 2 commits March 12, 2025 14:10

Merge branch 'master' into qt6

bf2b36d

Fix implicit QString --> QFileInfo conversion

bd288e4

tresf mentioned this pull request Mar 15, 2025

Update CALF to 0.90.4 #7783

Merged

tresf added 2 commits March 15, 2025 17:20

Merge branch 'master' into qt6

4ba9393

Point submodule to lmms

1daea18

tresf mentioned this pull request Mar 21, 2025

Global Spacebar Play #7762

Merged

Merge branch 'master' into qt6

f1bee30

messmerd mentioned this pull request May 20, 2025

Upgrade to Windows 2022 / Visual Studio 2022 #7897

Merged

messmerd added 5 commits May 21, 2025 23:29

Merge branch 'master' into 'qt6'

043319c

Conflicts: AutomationClipView.cpp ClipView.cpp TrackContentWidget.cpp

Fix multiple deprecation warnings

02f35ed

Fix for Clang compiler

6b59994

Build with latest Qt LTS version now that we use MSVC 2022

cf4bf5c

Update jurplel/install-qt-action to v4.3.0

a71147e

messmerd added 8 commits July 10, 2025 16:20

Bump minimum Qt6 version for MSVC

5f740e4

Fix incorrect Qt version checks

4f58756

Some comparisons were using ">" rather than ">="

QSize() != QSize(0, 0)

9f93dde

Merge branch 'master' into qt6

903572e

Conflicts: - src/gui/MainWindow.cpp

Fix more deprecation warnings

418a680

Fix style

87d6b91

Simplify Spectrum Analyzer mouse events

10969b1

The Qt bug that used to be present appears to have been fixed, so the workaround can be removed

Minor changes

48422da

messmerd reviewed Jul 11, 2025

View reviewed changes

messmerd added the needs testing This pull request needs more testing label Jul 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add Qt6 Support #7339

Add Qt6 Support #7339

tresf commented Jun 22, 2024 •

edited by PhysSong

Loading

Uh oh!

messmerd commented Oct 23, 2024

Uh oh!

tresf commented Feb 9, 2025 •

edited

Loading

Uh oh!

messmerd commented Feb 9, 2025

Uh oh!

Uh oh!

Uh oh!

tresf commented Feb 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as outdated.

This comment was marked as off-topic.

Uh oh!

tresf commented Mar 31, 2025

Uh oh!

messmerd commented Jul 10, 2025 •

edited

Loading

Uh oh!

messmerd left a comment

Uh oh!

messmerd Jul 11, 2025

Uh oh!

messmerd Jul 11, 2025

Uh oh!

messmerd commented Jul 11, 2025

Uh oh!

Uh oh!

Uh oh!

Add Qt6 Support #7339

Are you sure you want to change the base?

Add Qt6 Support #7339

Conversation

tresf commented Jun 22, 2024 • edited by PhysSong Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

messmerd commented Oct 23, 2024

Uh oh!

tresf commented Feb 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

messmerd commented Feb 9, 2025

Uh oh!

Uh oh!

Uh oh!

tresf commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as outdated.

This comment was marked as off-topic.

Uh oh!

tresf commented Mar 31, 2025

Uh oh!

messmerd commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

messmerd left a comment

Choose a reason for hiding this comment

Uh oh!

messmerd Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

messmerd Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

messmerd commented Jul 11, 2025

Testing instructions

Uh oh!

Uh oh!

tresf commented Jun 22, 2024 •

edited by PhysSong

Loading

tresf commented Feb 9, 2025 •

edited

Loading

tresf commented Feb 18, 2025 •

edited

Loading

messmerd commented Jul 10, 2025 •

edited

Loading