Skip to content

Adding stub methods to LightCurve that child classes must implement.#67

Merged
drewoldag merged 2 commits intomainfrom
issue/63/LightCurve-stub-methods
Oct 31, 2024
Merged

Adding stub methods to LightCurve that child classes must implement.#67
drewoldag merged 2 commits intomainfrom
issue/63/LightCurve-stub-methods

Conversation

@drewoldag
Copy link
Collaborator

After conversation with @AmandaWasserman, these two methods seem to be the only two that are required to be implemented by the subclasses of LightCurve.

@drewoldag drewoldag self-assigned this Oct 31, 2024
@drewoldag drewoldag linked an issue Oct 31, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 31, 2024

Before [04d3e6b] After [b84746f] Ratio Benchmark (Parameter)
144±2ms 152±7ms 1.06 benchmarks.time_feature_creation
155±5ms 157±3ms 1.01 benchmarks.time_learn_loop('KNN', 'RandomSampling')
195M 195M 1 benchmarks.peakmem_learn_loop('KNN')
186M 186M 1 benchmarks.peakmem_learn_loop('RandomForest')
161±3ms 161±1ms 1 benchmarks.time_learn_loop('KNN', 'UncSampling')
2.61±0.01s 2.61±0.02s 1 benchmarks.time_learn_loop('RandomForest', 'RandomSampling')
2.67±0.02s 2.67±0.02s 1 benchmarks.time_learn_loop('RandomForest', 'UncSampling')

Click here to view all benchmarks.

@drewoldag drewoldag changed the title Adding stub classes to LightCurve that child classes must implement. Adding stub ~classes~ methods to LightCurve that child classes must implement. Oct 31, 2024
@drewoldag drewoldag changed the title Adding stub ~classes~ methods to LightCurve that child classes must implement. Adding stub ~~classes~~ methods to LightCurve that child classes must implement. Oct 31, 2024
@drewoldag drewoldag changed the title Adding stub ~~classes~~ methods to LightCurve that child classes must implement. Adding stub methods to LightCurve that child classes must implement. Oct 31, 2024
@drewoldag drewoldag merged commit 56fad73 into main Oct 31, 2024
@drewoldag drewoldag deleted the issue/63/LightCurve-stub-methods branch October 31, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicitly state the methods a subclass of LightCurve must implement

2 participants