Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding stub methods to LightCurve that child classes must implement. #67

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Adding stub methods to LightCurve that child classes must implement. #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3213bb6
Adding stub classes to LightCurve that child classes must implement.
drewoldag Oct 31, 2024
0d1fcc8
Merge branch 'main' into issue/63/LightCurve-stub-methods
drewoldag Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/resspect/feature_extractors/light_curve.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,28 @@ def __init_subclass__(cls):

FEATURE_EXTRACTOR_REGISTRY[cls.__name__] = cls

def fit(self, band: str) -> np.ndarray:
"""
Extract features for one filter.

Parameters
----------
band: str
Choice of broad band filter

Returns
-------
np.ndarray
"""
raise NotImplementedError()

def fit_all(self):
"""
Performs feature extraction for all filters independently and concatenate results.
Populates self.features.
"""
raise NotImplementedError()

def _get_snpcc_photometry_raw_and_header(
self, lc_data: np.ndarray,
sntype_test_value: str = "-9") -> Tuple[np.ndarray, list]:
Expand Down
Loading