Rework loot table view #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current view only displays one item per line, which becomes a problem when loot tables are large. As loot tables are mainly about what items are in them, this PR simplifies the view to just show an inline list of slots, just like LU's inventory does. As for the other columns, `id` never seems to be used in the game and is probably an auto-added primary key. `missionDrop` is indicated by highlighting the slot. `sortPriority` is not displayed directly, but is used to order the items. Sorting is also moved from JS to CSS, as it is only used in presentation. As `sortPriority` is also only used by LU to order items, without the precise value being of much importance, not displaying it directly seems like an acceptable tradeoff for a much more compact representation of loot tables.
Xiphoseer
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current view only displays one item per line, which becomes a problem when loot tables are large ( Example ). As loot tables are mainly about what items are in them, this PR simplifies the view to just show an inline list of slots, just like LU's inventory does. As for the other columns,
idnever seems to be used in the game and is probably an auto-added primary key.missionDropis indicated by highlighting the slot.sortPriorityis not displayed directly, but is used to order the items. Sorting is also moved from JS to CSS, as it is only used in presentation. AssortPriorityis also only used by LU to order items, without the precise value being of much importance, not displaying it directly seems like an acceptable tradeoff for a much more compact representation of loot tables.