Split MainchainService into ValidatorService and WalletService, update ValidatorService #5
Conversation
Ash-L2L
changed the title
| rpc GenerateBlocks(GenerateBlocksRequest) | ||
| returns (GenerateBlocksResponse); |
There was a problem hiding this comment.
I think this can be axed. Generating blocks currently happens through the contrib/signet/miner script provided by Bitcoin Core, with minor tweaks by us. I'm currently working on a tweak here where we pass in CLI args for extra OP_RETURN messages that we want to add, which will let us do sidechain management. If we instead do generation through the wallet service, I think it'll end up being very hairy and complex
There was a problem hiding this comment.
This is only for Regtest mode, so the signet script is irrelevant
There was a problem hiding this comment.
So what I'm thinking for signet is:
- The validator exposes an endpoint for constructing the correct M{1-6} OP_RETURN messages
- The signet miner script takes in these OP_RETURN messages, adding them to the coinbase vouts
For mining on regtest, the signet miner script could be modified to remove the signet parts, but keep the rest. Sidechain management on signet needs to be implemented anyways, and we need not too-cumbersome ways of doing this on regtest as well. I.e. not re-implement the block construction logic.
The way bitcoin-cli does it with -generate does not work for us. Under the hood that defers to generatetoaddress, and there's no way of specifying coinbase outputs there.
Ash-L2L
force-pushed
the
ash/proto
branch
2 times, most recently
from
d2a3a92
to
788ef35
Compare
| @@ -233,8 +178,8 @@ message GetSidechainProposalsRequest { | |||
| message GetSidechainProposalsResponse { | |||
| message SidechainProposal { | |||
| uint32 sidechain_number = 1; | |||
| bytes data = 2; | |||
| bytes data_hash = 3; | |||
| google.protobuf.BytesValue data = 2; | |||
There was a problem hiding this comment.
Would it make sense to decode this data into a meaningful message? I.e. version, title, description and the two hashes
https://github.com/bitcoin/bips/blob/master/bip-0300.mediawiki#m1----propose-sidechain
No description provided.