Full tests and robustnes against frame ID wrapping for packet decoding #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do different partition and dataset scenarios that trigger carry situations
…f packets in wrapup Make sure we catch near-range stragglers if there is unfinished work. That way we "survive" massive scrambling within the range of one tile. Adapt test cases accordingly; also test dups which is trivial.
Use a "virtual corrected frame ID" and correct wrap already during decoding. Wrapping is detected directly after processing packets and is corrected as early as possible. To not get mixed up in "old" and "new" epoch, the decoded header is stored in the carry buffers.
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Test for wrapping was flaky for 128 scrambling, test it only for less aggressive scrambling. In reality, inconsistencies in the data stream are rare, and the packets are almost always in order, so jump detection will work with high reliablity.
Also fix comments from before The tests are still flaky sometimes, more work to be done
|
As a note, there is still a flaky test in this PR which we want to fix before it can be merged. |
sk1p
changed the title
* Account for stragglers in test * Refine test matrix to exclude combinations that can "trip" the packet reordering. The test is already much harder than the actual data stream, which is almost always in order and complete with only very few missing, scrambled or duplicate packets.
uellue
changed the title
|
/azp run libertem.libertem-live-data |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
The k2is branch should be rebased to current master for tests to work -- setup.py is broken, etcetc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist:
Reviewer Checklist:
/azp run libertem.libertem-live-datapassed