-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full tests and robustnes against frame ID wrapping for packet decoding #19
Open
uellue
wants to merge
7
commits into
LiberTEM:k2is
Choose a base branch
from
uellue:origin/k2is
base: k2is
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 23, 2021
-
Test for partition and dataset carry
Do different partition and dataset scenarios that trigger carry situations
Configuration menu - View commit details
-
Copy full SHA for a71dca5 - Browse repository at this point
Copy the full SHA a71dca5View commit details -
Detect completion correctly for "tail" tiles; process one more load o…
…f packets in wrapup Make sure we catch near-range stragglers if there is unfinished work. That way we "survive" massive scrambling within the range of one tile. Adapt test cases accordingly; also test dups which is trivial.
Configuration menu - View commit details
-
Copy full SHA for fc1f826 - Browse repository at this point
Copy the full SHA fc1f826View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fb48be - Browse repository at this point
Copy the full SHA 0fb48beView commit details -
Use a "virtual corrected frame ID" and correct wrap already during decoding. Wrapping is detected directly after processing packets and is corrected as early as possible. To not get mixed up in "old" and "new" epoch, the decoded header is stored in the carry buffers.
Configuration menu - View commit details
-
Copy full SHA for 1a622a7 - Browse repository at this point
Copy the full SHA 1a622a7View commit details
Commits on Jun 24, 2021
-
Avoid memory allocation for copies
Test for wrapping was flaky for 128 scrambling, test it only for less aggressive scrambling. In reality, inconsistencies in the data stream are rare, and the packets are almost always in order, so jump detection will work with high reliablity.
Configuration menu - View commit details
-
Copy full SHA for e230e5c - Browse repository at this point
Copy the full SHA e230e5cView commit details -
Also fix comments from before The tests are still flaky sometimes, more work to be done
Configuration menu - View commit details
-
Copy full SHA for 8679810 - Browse repository at this point
Copy the full SHA 8679810View commit details
Commits on Jul 22, 2021
-
* Account for stragglers in test * Refine test matrix to exclude combinations that can "trip" the packet reordering. The test is already much harder than the actual data stream, which is almost always in order and complete with only very few missing, scrambled or duplicate packets.
Configuration menu - View commit details
-
Copy full SHA for 53a76ed - Browse repository at this point
Copy the full SHA 53a76edView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.