Skip to content

fix: update comet_ml logger for compatibility #20275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Mar 12, 2025

fix comet logger test

9e7a3cc
Select commit
Loading
Failed to load commit list.
Merged

fix: update comet_ml logger for compatibility #20275

fix comet logger test
9e7a3cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 12, 2025 in 0s

79% (target 99%)

Details

Codecov Report

Attention: Patch coverage is 82.81250% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79%. Comparing base (a0134d2) to head (9e7a3cc).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a0134d2) and HEAD (9e7a3cc). Click for more details.

HEAD has 321 uploads less than BASE
Flag BASE (a0134d2) HEAD (9e7a3cc)
cpu 96 24
lightning 61 15
pytest 51 0
python3.11 24 6
python3.10 24 6
python 12 3
lightning_fabric 20 0
gpu 3 0
python3.12.7 36 9
pytorch2.1 12 6
pytorch_lightning 18 9
pytest-full 48 24
pytorch2.2.2 6 3
pytorch2.5 6 3
pytorch2.3 6 3
pytorch2.4.1 6 3
pytorch2.5.1 6 3
pytorch2.6 6 3
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20275     +/-   ##
=========================================
- Coverage      88%      79%     -9%     
=========================================
  Files         267      264      -3     
  Lines       23373    23301     -72     
=========================================
- Hits        20483    18348   -2135     
- Misses       2890     4953   +2063     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.