Expose attribute aliases in list of attributes #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
alias_attribute_access
branch
from
38d375b to
489e623
Compare
2 tasks
jrafanie
reviewed
Jan 30, 2025
| @@ -21,7 +21,7 @@ def attribute_selection | |||
| if !@req.attributes.empty? || @additional_attributes | |||
| @req.attributes | Array(@additional_attributes) | ID_ATTRS | |||
| else | |||
| Picture.attribute_names - %w(content) | |||
| Picture.attribute_names | Picture.try(:attribute_aliases)&.keys - %w(content) | |||
There was a problem hiding this comment.
56 tasks
|
I made a comment in the other PR, but I don't understand this. Does this not return the same thing in Rails 7.1 as in 7.0? In 7.0 the |
3 tasks
kbrock
changed the title
|
WIP: introducing more generic method for the concept of attributes and attribute aliases. After that is done, will change this code to leverage that. |
kbrock
force-pushed
the
alias_attribute_access
branch
from
489e623 to
8383a3d
Compare
kbrock
changed the title
|
update:
un-WIP |
kbrock
force-pushed
the
alias_attribute_access
branch
from
8383a3d to
f2d7ff9
Compare
kbrock
force-pushed
the
alias_attribute_access
branch
from
f2d7ff9 to
a92ad3d
Compare
This assertion on the response body fails against master code before this branch. I think the intention was to test that creation with a virtual columns works.
1 task
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Feb 17, 2025
Fixes deprecation of this variety: Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually. This also handles aliases on association methods We use runtime method delegation instead of class load time alias_method. In Rails 7.1, the attribute/association methods aren't defined at class load time so we can't alias them. Note, we can remove virtual_column/attribute on actual attributes with alias_attribute due to: ManageIQ#23324 ManageIQ/manageiq-automation_engine#565 ManageIQ/manageiq-api#1278 ManageIQ#23321
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Feb 17, 2025
Fixes deprecation of this variety: Foo model aliases `x`, but `x` is not an attribute. Starting in Rails 7.2, alias_attribute with non-attribute targets will raise. Use `alias_method :y, :x` or define the method manually. This also handles aliases on association methods We use runtime method delegation instead of class load time alias_method. In Rails 7.1, the attribute/association methods aren't defined at class load time so we can't alias them. Note, we can remove virtual_column/attribute on actual attributes with alias_attribute due to: ManageIQ#23324 ManageIQ/manageiq-automation_engine#565 ManageIQ/manageiq-api#1278 ManageIQ#23321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked:
This enables fixes for 7.1
But this does not depend upon 7.1 and even in 7.0 is a more accurate implementation