-
Notifications
You must be signed in to change notification settings - Fork 487
terraform test: Add some interesting td files and make the cleanup more robust, speed up mz-debug build #32228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bobbyiliev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like some tests are failing with:
error: executing query failed: db error: ERROR: unknown cluster replica size 1
--
| HINT: Valid cluster replica sizes are: mz_probe, 25cc, 50cc, 100cc, 200cc, 300cc, 400cc, 600cc, 800cc, 1200cc, 1600cc, 3200cc, 6400cc: ERROR: unknown cluster replica size 1
| HINT: Valid cluster replica sizes are: mz_probe, 25cc, 50cc, 100cc, 200cc, 300cc, 400cc, 600cc, 800cc, 1200cc, 1600cc, 3200cc, 6400cc
| \|
| 10 \| > DROP CLUSTER IF EXISTS gh_6942_cluster CASCADE;
| 11 \| > CREATE CLUSTER gh_6942_cluster SIZE '1', REPLICATION FACTOR 1;
| \| ^
68fa632 to
d450619
Compare
d450619 to
6b1dc0d
Compare
b9551f7 to
d19d898
Compare
|
Finally a green run: https://buildkite.com/materialize/nightly/builds/11904 |
Saves ~7 min. We need to wait for terraform anyway
57454c3 to
6b337d1
Compare
This reverts commit f53418b.
6b337d1 to
b686a30
Compare
bobbyiliev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.