Skip to content

Conversation

@def-
Copy link
Contributor

@def- def- commented Apr 16, 2025

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some tests are failing with:

error: executing query failed: db error: ERROR: unknown cluster replica size 1
--
  | HINT: Valid cluster replica sizes are: mz_probe, 25cc, 50cc, 100cc, 200cc, 300cc, 400cc, 600cc, 800cc, 1200cc, 1600cc, 3200cc, 6400cc: ERROR: unknown cluster replica size 1
  | HINT: Valid cluster replica sizes are: mz_probe, 25cc, 50cc, 100cc, 200cc, 300cc, 400cc, 600cc, 800cc, 1200cc, 1600cc, 3200cc, 6400cc
  | \|
  | 10 \| > DROP CLUSTER IF EXISTS gh_6942_cluster CASCADE;
  | 11 \| > CREATE CLUSTER gh_6942_cluster SIZE '1', REPLICATION FACTOR 1;
  | \| ^

@def- def- force-pushed the pr-terraform-again branch 7 times, most recently from 68fa632 to d450619 Compare April 17, 2025 13:40
@def- def- requested a review from a team as a code owner April 17, 2025 13:40
@def- def- force-pushed the pr-terraform-again branch from d450619 to 6b1dc0d Compare April 17, 2025 14:37
@def- def- requested a review from bobbyiliev April 17, 2025 15:18
@def- def- force-pushed the pr-terraform-again branch 8 times, most recently from b9551f7 to d19d898 Compare April 23, 2025 05:58
@def-
Copy link
Contributor Author

def- commented Apr 23, 2025

@def- def- force-pushed the pr-terraform-again branch 3 times, most recently from 57454c3 to 6b337d1 Compare April 23, 2025 07:31
@def- def- force-pushed the pr-terraform-again branch from 6b337d1 to b686a30 Compare April 23, 2025 08:23
@def- def- enabled auto-merge April 23, 2025 08:44
@def- def- changed the title terraform test: Add some interesting td files terraform test: Add some interesting td files and make the cleanup more robust Apr 23, 2025
@def- def- changed the title terraform test: Add some interesting td files and make the cleanup more robust terraform test: Add some interesting td files and make the cleanup more robust, speed up mz-debug build Apr 23, 2025
Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@def- def- merged commit 4dc3c59 into MaterializeInc:main Apr 23, 2025
84 checks passed
@def- def- deleted the pr-terraform-again branch April 23, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants