Added 100+ New Quirks, Refactored Personality Traits & Quirk Classes #5088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced `toString()` with `ordinal()` for enum serialization in `Person.java`. Updated deserialization to handle both ordinal and string formats for backward compatibility. Ensured correct parsing and logging in related classes.
Removed multiple redundant boolean comparison methods from Aggression, Ambition, and Greed enums. The simplification reduces code bloat and enhances maintainability by avoiding unnecessary duplication.
Improved readability by adding line continuation characters in long description strings of personality traits in Personalities.properties. This change helps maintain clarity and manage lines within the 80-character limit.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5088 +/- ##
============================================
+ Coverage 10.42% 10.52% +0.10%
- Complexity 6028 6032 +4
============================================
Files 953 953
Lines 134113 133886 -227
Branches 19435 19443 +8
============================================
+ Hits 13979 14090 +111
+ Misses 118785 118449 -336
+ Partials 1349 1347 -2 ☔ View full report in Codecov by Sentry. |
|
The deprecated warnings can be ignored: I was the one who deprecated those methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds around 100 new personality quirks, more than doubling the pool. It also adjusts saving and loading of traits to use ordinal values rather than hardcoded. This will make adding new quirks much easier and is just cleaner code. I also removed a bunch of unused boolean comparators.