Added Empty Jump Path Check UnableToAffordJumpNagDialog
#5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevented the 'UnableToAffordJumpNagDialog' nag from appearing if jump path is empty.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5089 +/- ##
=========================================
Coverage 10.42% 10.42%
- Complexity 6028 6032 +4
=========================================
Files 953 953
Lines 134113 134129 +16
Branches 19435 19440 +5
=========================================
+ Hits 13979 13987 +8
- Misses 118785 118793 +8
Partials 1349 1349 ☔ View full report in Codecov by Sentry. |
Added checks to handle scenarios where the jump cost is zero, preventing unnecessary dialogs. Ensured that the dialog does not display if the cost of the next jump is zero or if the current system is the last system on the jump path.
HammerGS
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevented the 'UnableToAffordJumpNagDialog' nag from appearing if jump path is empty, or the campaign is in transit to the final planet in the Jump Path.
Closes #4988