Prevent Early Clan Units in Non-Clan Campaigns #5094
Conversation
Added a check to prevent Clan units from appearing in the unit market for non-Clan campaigns, prior to the fifth wave of invasion. This ensures historical accuracy by removing early access to Clan technology. I chose the fifth wave of invasion, as that seems a reasonable point by which the proliferation of Clan technology (while not common) would likely begin across the Inner Sphere.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5094 +/- ##
============================================
+ Coverage 10.42% 10.54% +0.11%
- Complexity 6035 6036 +1
============================================
Files 953 955 +2
Lines 134268 134150 -118
Branches 19456 19474 +18
============================================
+ Hits 14003 14143 +140
+ Misses 118922 118665 -257
+ Partials 1343 1342 -1 ☔ View full report in Codecov by Sentry. |
| @@ -191,8 +191,20 @@ public abstract void addOffers(final Campaign campaign, final int number, UnitMa | |||
| public String addSingleUnit(final Campaign campaign, final UnitMarketType market, | |||
| final int unitType, final MekSummary mekSummary, | |||
| final int percent) { | |||
| final LocalDate INVASION_WAVE_FIVE = LocalDate.of(3051, 11, 1); | |||
There was a problem hiding this comment.
How about we turn this into a variable players can manage. Most of the Clan equipment starts to hit later per Merc 3055, After The Battle of Tukayyid in May of 3052.
This isn't a thing for this PR but we should also be modelling that prior to this most houses (FRR and Kurita being the exception) weren't giving salvage rights to Mercs but exchange.
There was a problem hiding this comment.
Happy to change this to after Tukayyid, but not interested in adding new campaign options until after CO IIC is merged as it just makes extra work for me to incorporate into CO IIC.
Replaced the "Invasion Wave Five" date with the Battle of Tukayyid date in the addSingleUnit method.
|
Switched cut-off date from the fifth wave to the Battle of Tukayyid, as per Hammer's feedback. Description updated accordingly. |
Added a check to prevent Clan units from appearing in the unit market for non-Clan campaigns, prior to the conclusion of the battle of Tukayyid.
Closes #4975