Updated Interstellar Map View Defaults & Optimized 'ISW' view #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the system capital and hiring hall rendering to use faction-specific colors and adjusted the arc rendering to improve visual clarity. Added a check for "GREAT" Hiring Hall levels and modified the painting logic accordingly.
Replaced the "ISW Areas" checkbox with "Territory" and updated the related rendering logic to improve faction territory display. Also removed the unused import statement of `Collectors`. This refactor enhances the readability and accuracy of the territory visualization in the InterstellarMapPanel.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5107 +/- ##
=========================================
Coverage 10.54% 10.54%
- Complexity 6038 6044 +6
=========================================
Files 955 956 +1
Lines 134147 134188 +41
Branches 19472 19479 +7
=========================================
+ Hits 14143 14149 +6
- Misses 118659 118697 +38
+ Partials 1345 1342 -3 ☔ View full report in Codecov by Sentry. |
Renamed the 'independentFaction' variable to 'indFaction' for brevity and consistency. This change affects multiple locations within the InterstellarMapPanel class where faction checks are performed.
Changed the color of the circle from semi-transparent black to dark grey when certain conditions were not met. This ensures better visual consistency and readability in the interstellar map display.
Implemented a new dashedThick stroke and applied it to the contract search radius, planetary acquisition radius, and jump radius arcs.
HammerGS
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the interstellar map to make the old ISW the default. It makes some substantial optimizations under the hood to ISW to make it less of a resource hog. As well as some general visual changes to that view and renamed it to 'Territory'.
This has a few added benefits. In addition to looking closer to CGL's official maps, the territory won't disappear when the user changes map filters. So you avoid situations like the image below:
Instead you get...
