Stopped Scenarios Pulling Units from the Hangar #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain scenarios are set up to substitute enemy units with player units. Typically, this is the DropShip scenarios optionally using player DropShips. Previously, this could pull units from the players' hangar. Now it is restricted to units in the TO&E.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5137 +/- ##
=========================================
Coverage 10.53% 10.54%
- Complexity 6041 6050 +9
=========================================
Files 956 956
Lines 134253 134270 +17
Branches 19501 19507 +6
=========================================
+ Hits 14142 14156 +14
- Misses 118760 118763 +3
Partials 1351 1351 ☔ View full report in Codecov by Sentry. |
|
Closing as resolved |
|
Closed the wrong case - reopening |
Revised the logic for determining eligible units in the campaign. Made all units in the TO&E eligible by default and handled units using a seed force separately for transport eligibility. Improved error handling and logging during unit retrieval.
HammerGS
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain scenarios are set up to substitute enemy units with player units. Typically, this is the DropShip scenarios optionally using player DropShips. Previously, this could pull units from the players' hangar. Now it is restricted to units in the TO&E.