[FG3] Adjusted Generation Method in Some Scenarios #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the generationMethod from 2 to 1 across several scenario template XML files. This adjustment ensures consistency in the force generation approach for Convoy and Irregular Force scenarios.
IllianiCBT
added
the
Force Generation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5144 +/- ##
=========================================
Coverage 10.53% 10.53%
- Complexity 6041 6045 +4
=========================================
Files 956 956
Lines 134253 134264 +11
Branches 19501 19506 +5
=========================================
+ Hits 14142 14150 +8
- Misses 118760 118765 +5
+ Partials 1351 1349 -2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
generationMethodfrom 2 (fixed unit count) to 1 (BV) across several scenario templates. This will need to be monitored, but will better ensure these scenarios scale more appropriately with the player force.