Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fg3] Refactored Difficulty Multiplier Application #5145

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

IllianiCBT
Copy link
Collaborator

Moved difficulty multiplier application exclusively to enemy forces. Previously it was being applied to both player and enemy forces. This meant that, if the player was playing with a low difficulty, their allies would have their force budgets slashed.

I also did a couple of minor reporting changes. Nothing of note.

Moved difficulty multiplier application exclusively to enemy forces. Removed redundant multiplier from player unit and BV budgets and added detailed logging for generated forces.
@IllianiCBT IllianiCBT added Bug Force Generation Anything related to Force Generation (Opfor or Friendly) labels Oct 28, 2024
@IllianiCBT IllianiCBT self-assigned this Oct 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.53%. Comparing base (fb6c52a) to head (cbff0b0).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5145   +/-   ##
=========================================
  Coverage     10.53%   10.53%           
- Complexity     6041     6046    +5     
=========================================
  Files           956      956           
  Lines        134253   134263   +10     
  Branches      19501    19505    +4     
=========================================
+ Hits          14142    14151    +9     
+ Misses       118760   118757    -3     
- Partials       1351     1355    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit b561291 into MegaMek:master Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Force Generation Anything related to Force Generation (Opfor or Friendly)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants