Improvement: Migrated Skill Type Utility Methods into Their Own Class #7632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few months ago I promised Luana that I would rewrite our SkillType class, converting it into an enum instead of the weird array thing we currently have. This PR is the first step in that direction, moving various utility methods into their own utility class.
The next step will be the enum migration itself. However, as that's liable to be a chunky PR, I wanted to be kind on whoever reviews the PR by moving this initial setup work into its own PR.
As this PR touches on a wide swathe of the codebase I'm expecting copilot to find a bunch of issues. However, unless those issues relate directly to this refactor they will not be addressed. That is to ensure we're not introducing new issues with this change and to retain some degree of change scope.