Skip to content

Conversation

@IllianiBird
Copy link
Collaborator

With the removal of Combat Technicians/Engineers players immediately voiced a need for a way to filter personnel out of the salvage tech picker dialog. This flag allows them to do so.

As of this PR only characters with the 'Salvage Supervisor' flag can participate in salvage operations. Whether this flag is enabled or disabled by default is determined by a campaign option (set to enabled by default by default).

While I was adding this flag I also spotted that we were being very inconsistent with how we were handling flag toggling. So I updated that.

@IllianiBird IllianiBird self-assigned this Nov 20, 2025
@IllianiBird IllianiBird requested a review from a team as a code owner November 20, 2025 01:11
@IllianiBird IllianiBird added the UX User experience label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 2.22222% with 88 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.73%. Comparing base (f130d04) to head (935faf4).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
.../mekhq/gui/adapter/PersonnelTableMouseAdapter.java 0.00% 63 Missing ⚠️
...mekhq/gui/campaignOptions/contents/MarketsTab.java 0.00% 7 Missing ⚠️
MekHQ/src/mekhq/campaign/personnel/Person.java 14.28% 6 Missing ⚠️
MekHQ/src/mekhq/gui/BriefingTab.java 0.00% 6 Missing ⚠️
...ekhq/campaign/campaignOptions/CampaignOptions.java 25.00% 3 Missing ⚠️
...ign/campaignOptions/CampaignOptionsMarshaller.java 0.00% 2 Missing ⚠️
...n/campaignOptions/CampaignOptionsUnmarshaller.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8250   +/-   ##
=========================================
  Coverage     11.72%   11.73%           
- Complexity     7532     7536    +4     
=========================================
  Files          1271     1271           
  Lines        162724   162743   +19     
  Branches      24515    24526   +11     
=========================================
+ Hits          19082    19097   +15     
- Misses       141644   141648    +4     
  Partials       1998     1998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UX User experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant